Last Comment Bug 658093 - BuildFileList can potentially try to read a signature beyond the end of the zip file
: BuildFileList can potentially try to read a signature beyond the end of the z...
Status: RESOLVED FIXED
: crash
Product: Core
Classification: Components
Component: Networking: JAR (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-18 15:56 PDT by Michael Wu [:mwu]
Modified: 2011-05-22 10:06 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (2.12 KB, patch)
2011-05-19 12:25 PDT, Michael Wu [:mwu]
taras.mozilla: review+
Details | Diff | Review

Description Michael Wu [:mwu] 2011-05-18 15:56:55 PDT

    
Comment 1 Michael Wu [:mwu] 2011-05-19 12:25:53 PDT
Created attachment 533753 [details] [diff] [review]
Fix

This test doesn't always crash unless gdb is attached for some reason.
Comment 2 (dormant account) 2011-05-19 13:15:12 PDT
Comment on attachment 533753 [details] [diff] [review]
Fix

r+ with buf + PRInt32(sizeof(PRUint32)) < endp
Comment 3 Michael Wu [:mwu] 2011-05-22 10:06:49 PDT
http://hg.mozilla.org/mozilla-central/rev/8834e11cf6bf

Note You need to log in before you can comment on or make changes to this bug.