658112 - runOrNotFunc returning false still has data being submitted

Status: RESOLVED DUPLICATE of bug 658134

(Mozilla Labs Graveyard :: Test Pilot, defect, P2)

Description

[Ed Lee :Mardak]

I'm looking through some initial results and some are missing metadata. I noticed that the ones missing study-specific metadata are reporting locations like pt-BR and de.

So the study is correctly not running:

  runOrNotFunc: function() {
    let channel = Services.prefs.getCharPref("app.update.channel");
    let locale = Services.prefs.getCharPref("general.useragent.locale");
    return channel != "release" && locale == "en-US";
  },

But somehow they are submitting generic metadata.

Comment 1

[Ed Lee :Mardak]

Fyi, you can watch "[e-mail]" to automatically get bugs relating to Test Pilot without having to be CC'd.

Comment 2

[Jono Xia]

I wonder if this is related to the other bug you found, where 1.0.4 users would submit an empty event set even on studies that were supposed to be minimum 1.1.  Both runOrNot and minTPVersion are handled by the same code, which is not supposed to let the study run.

...but maybe there's an underlying bug where even a study that never ran can still be submitted?  That needs to be investigated.  Thanks for finding this problem.

Comment 3

[Ed Lee :Mardak]

Oh turns out these non-enUS submissions seem to all have old test pilot. Duping to bug 658134.