Add API for iterating over the entire GC heap

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: njn, Assigned: billm)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 533491 [details] [diff] [review]
patch

This is spun off from bug 571249, which will use the API to count how much heap memory is used by object slot arrays and string characters.

I'm carrying over the r+ from Igor, and adding my own r+ for the minor changes that have happened since Igor's review (the per-kind and per-compartment restrictions, and hoisting the GetFinalizableTraceKind call out of the loop).
Attachment #533491 - Flags: review+
(Reporter)

Comment 1

6 years ago
If 656261 lands in the meantime, this patch'll need updating.

I really want to land this before cdleary does the TM-to-mc merge on Friday, so that bug 571249 can make it into Firefox 6.  Hopefully we three (njn, igor, billm) can co-ordinate things so this happens.
Blocks: 571249
(Reporter)

Updated

6 years ago
Depends on: 656261

Comment 2

6 years ago
(In reply to comment #1)
> If 656261 lands in the meantime, this patch'll need updating.

It looks I need more work with the patch for the bug 656261. If I will fix it today, I will update the patch here as well. If not, just proceed with landing here.
(Reporter)

Comment 3

6 years ago
http://hg.mozilla.org/tracemonkey/rev/fc1369652e84
Whiteboard: fixed-in-tracemonkey
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/fc1369652e84
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.