make_mark will error out when requested with GET

VERIFIED FIXED in 1.1

Status

Websites
markup.mozilla.org
--
minor
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: wenzel, Assigned: brez)

Tracking

unspecified

Details

(Reporter)

Description

7 years ago
When calling /makemark with GET it will error out because mark_form will be unset:

https://github.com/mozilla/markup/blob/eba161a8973d88302fde7e1d8de827eb63234026/ffdemo/markup/views.py#L107

Suggested solution: Django has a @require_POST decorator. Use it.
Blocks: 628811
Target Milestone: --- → 1.1
(Assignee)

Updated

7 years ago
Assignee: nobody → jbresnik
(Assignee)

Comment 1

7 years ago
Added

https://github.com/mozilla/markup/commit/5a32c936d080529d650440544400214dbf947020
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
wenzel, can you verify :)
(Reporter)

Comment 3

6 years ago
This should work, but it has an unused import. Please fix, then re-close.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

6 years ago
All set

https://github.com/mozilla/markup/commit/878a990ae6ff6ff966d5889afcb6499a5125b01e
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → FIXED
thx brez and wenzel.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.