Closed Bug 658164 Opened 13 years ago Closed 13 years ago

The new add-ons manager accepts <em:type>extension</em:type> as a valid type

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla7

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file)

patch rev 1
5.70 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
Accidentally added this in the rewrite and didn't mean to.
Would it be so bad to keep it?
I don't want to have to be tied to supporting (and testing) both forms. I would be in favour of switching to strings if we were to move to a new style of install manifest (i.e. not RDF) but as a clean switch.
Attached patch patch rev 1 — — Splinter Review 

        Attachment #536983 -
        Flags: review?(robert.bugzilla)

    
  
Status: NEW → ASSIGNED
Whiteboard: [has patch][needs review rs]

    
    

    
  
Comment on attachment 536983 [details] [diff] [review]
patch rev 1

Looks straightforward enough

        Attachment #536983 -
        Flags: review?(robert.bugzilla) → review+
Whiteboard: [has patch][needs review rs] → [has patch]

    
    

    
  
Landed: http://hg.mozilla.org/mozilla-central/rev/9ceea224f535
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → mozilla7

    
    

    
  
Verified fixed by check-in and passing tests.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.