If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Are shell scripts really binary?

RESOLVED FIXED in 6.0.10

Status

addons.mozilla.org Graveyard
Compatibility Tools
P3
normal
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: fligtar, Assigned: basta)

Tracking

Details

(Reporter)

Description

6 years ago
https://addons.allizom.org/en-US/developers/addon/chipmark/validation-result/4700 won't be upgraded because it contains a .sh script. Are they really considered binary?

I am concerned we'll get a lot of hits on this from people who have shell scripts to build/manage their add-ons.
They're in the 'forbidden file' category, with .class and others, but they're not binary component category that would be affected by a Firefox upgrade.

We should be only looking for .dll, .dylib and .so in the components, plugins or platform directories.
Matt: maybe we should make a completely new validator test case for this instead of re-using the regular binary check and changing it from a warning to an error.
Target Milestone: --- → 6.0.10
(Reporter)

Comment 3

6 years ago
Yeah, that sounds like it will fix the other problem of the error message (bug 658040) too. Ideally it would appear in the compatibility tests section.
Matt, can you add that?
Assignee: nobody → mbasta
(Assignee)

Comment 5

6 years ago
Sure thing, will get started on it ASAP.
(Assignee)

Comment 6

6 years ago
https://github.com/mozilla/amo-validator/pull/39
(Assignee)

Comment 7

6 years ago
Fixed:

https://github.com/mozilla/amo-validator/commit/9f6ef50e0dd255073757b6e8a2870b7950c5b8aa
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
In Zamboni as of https://github.com/jbalogh/zamboni-lib/commit/82945e1
Now that this is closed, for the sake of pedantic geekery:  shell scripts can absolutely include binary data.  (whether we care about that in the validator may be another story)
(In reply to comment #9)
> Now that this is closed, for the sake of pedantic geekery:  shell scripts
> can absolutely include binary data.  (whether we care about that in the
> validator may be another story)

Shell scripts are flagged by the validator as restricted files, so we're covered in that regard. They're not affected by the compatibility issue (outdated Gecko SDK build), so we don't need to include them in this particular check.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.