gVolumeScaleLock deadlock

RESOLVED FIXED in mozilla6

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

Trunk
mozilla6
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 533538 [details] [diff] [review]
Patch

No good deed goes unpunished. I landed Bug 652475 today, but that introduced a potential deadlock with `make xpcshell-tests`. It never showed up on TryServer for some reason, but aborts locally for me with a warning about potential deadlock.

http://pastebin.mozilla.org/1229597

The problem is I take the gVolumeScaleLock  and then read the media.volume_sale pref. I imagine that's taking a lock.
Attachment #533538 - Flags: review?(roc)
Comment on attachment 533538 [details] [diff] [review]
Patch

Review of attachment 533538 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #533538 - Flags: review?(roc) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/7ef763ba534b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.