Make all require args relative or "package/module" style for modules from other packages

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: irakli, Assigned: warner)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 obsolete attachments)

Comment hidden (empty)
Assignee: nobody → warner-bugzilla
Depends on: 652227
Created attachment 533629 [details]
Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2/files

Pointer to Github pull-request
Comment on attachment 533629 [details]
Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2/files

Adding pull request with changes replicating linker search logic in the securable-module. This is important in order to be sure that `require('foo/bar')` will return same thing for tests as well.

This is patch on top of brians work and since we want to land this changes together it was making more sense to attach patch here.
Attachment #533629 - Flags: review?(warner-bugzilla)
Comment on attachment 533629 [details]
Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2/files

Sorry wrong bug!
Attachment #533629 - Flags: review?(warner-bugzilla)
Created attachment 533631 [details]
Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2

Pointer to Github pull-request
Comment on attachment 533631 [details]
Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2

Adding pull request with changes replicating linker search logic in the securable-module. This is important in order to be sure that `require('foo/bar')` will return same thing for tests as well.

This is patch on top of brians work and since we want to land this changes together it was making more sense to attach patch here.
Attachment #533631 - Flags: review?(warner-bugzilla)
Attachment #533629 - Attachment is obsolete: true
Comment on attachment 533631 [details]
Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2

Sorry github-bugzilla extension got messed up!
Attachment #533631 - Attachment is obsolete: true
Attachment #533631 - Flags: review?(warner-bugzilla)
(Assignee)

Comment 7

7 years ago
This was landed as part of https://github.com/mozilla/addon-sdk/commit/658fb89ca4d3dc4a8cfb9616ae873e979a7f3955
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.