Closed
Bug 658198
Opened 13 years ago
Closed 13 years ago
Make all require args relative or "package/module" style for modules from other packages
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Assigned: warner)
References
Details
Attachments
(2 obsolete files)
No description provided.
Reporter | ||
Comment 1•13 years ago
|
||
Pointer to Github pull-request
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 533629 [details] Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2/files Adding pull request with changes replicating linker search logic in the securable-module. This is important in order to be sure that `require('foo/bar')` will return same thing for tests as well. This is patch on top of brians work and since we want to land this changes together it was making more sense to attach patch here.
Attachment #533629 -
Flags: review?(warner-bugzilla)
Reporter | ||
Comment 3•13 years ago
|
||
Comment on attachment 533629 [details] Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2/files Sorry wrong bug!
Attachment #533629 -
Flags: review?(warner-bugzilla)
Reporter | ||
Comment 4•13 years ago
|
||
Pointer to Github pull-request
Reporter | ||
Comment 5•13 years ago
|
||
Comment on attachment 533631 [details] Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2 Adding pull request with changes replicating linker search logic in the securable-module. This is important in order to be sure that `require('foo/bar')` will return same thing for tests as well. This is patch on top of brians work and since we want to land this changes together it was making more sense to attach patch here.
Attachment #533631 -
Flags: review?(warner-bugzilla)
Reporter | ||
Updated•13 years ago
|
Attachment #533629 -
Attachment is obsolete: true
Reporter | ||
Comment 6•13 years ago
|
||
Comment on attachment 533631 [details] Pointer to Github pull request: https://github.com/warner/addon-sdk/pull/2 Sorry github-bugzilla extension got messed up!
Attachment #533631 -
Attachment is obsolete: true
Attachment #533631 -
Flags: review?(warner-bugzilla)
Assignee | ||
Comment 7•13 years ago
|
||
This was landed as part of https://github.com/mozilla/addon-sdk/commit/658fb89ca4d3dc4a8cfb9616ae873e979a7f3955
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•