Add a timeout to ajax request in TBPL

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
7 years ago
3 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 533584 [details] [diff] [review]
Patch v1

Because of bug 657889, we can't access to build.mozilla.org from the Paris office which makes TBPL always showing "Loading 50%" with no error message. This patch adds a timeout value (10s) so an error message is shown when the URL isn't accessible.
Attachment #533584 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #533584 - Flags: review? → review?(mstange)
(Assignee)

Updated

7 years ago
Whiteboard: [needs review]
Attachment #533584 - Flags: review?(mstange) → review+
(Assignee)

Comment 1

7 years ago
Pushed:
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8c1153a543a5
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Depends on: 660184
Ah, this was why I was claiming in bug 657540 comment 6 that tip was broken, and would only load pushes and pending but not tinderbox, or pushes and tinderbox but not pending. I'm real happy that you all have nice fast connections, but if tbpl.m.o is going to insist that every part must load in 10 seconds or less, even when I'm on my fringe 3G connection restoring a session with three trees open, then I won't be able to use it anymore.
Can we add a query param for the timeout so it's possible to override the default value?
And apparently we only show the error message for a few parts, since I've only seen it once in 30 or 40 failed broken partial loads.
Depends on: 660423
(Assignee)

Comment 6

6 years ago
Marking this as WONTFIX given that I'm not planning to fix this. Feel free to reopen if someone wants to fix this bug.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → WONTFIX
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.