Closed Bug 658259 Opened 9 years ago Closed 9 years ago

Incorrect function tested in browser/components/sessionstore/test/browser/browser_345898.js

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: alastair, Assigned: mbrubeck)

References

()

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20110429 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20110429 Firefox/4.0.1

Line 77 in browser/components/sessionstore/test/browser/browser_345898.js tests getWindowValue, but the error message refers to setWindowValue.
It should probably be setWindowValue that is tested, as that function is not tested anywhere else in browser_345898.js

Reproducible: Always
Also, the tests on lines 73 and 75 are identical, which is a little odd.
Attached patch patchSplinter Review
Assignee: nobody → mbrubeck
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #533667 - Flags: review?(paul)
Comment on attachment 533667 [details] [diff] [review]
patch

Review of attachment 533667 [details] [diff] [review]:
-----------------------------------------------------------------

Alastair: thanks for catching that!
Matt: thanks for the quick fix :)
Attachment #533667 - Flags: review?(paul) → review+
Pushed to Try again, on more platforms: http://tbpl.mozilla.org/?tree=Try&rev=667f483f1b3f

This is green on all platforms; I'll push it to m-c tomorrow.
Bug 606681 is ready to go too (and might have a small context conflict). If you want to land that with this, that would be great. Otherwise I can land them.
I can land both patches today.
http://hg.mozilla.org/mozilla-central/rev/0cfa66a223ab
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
You need to log in before you can comment on or make changes to this bug.