Last Comment Bug 658259 - Incorrect function tested in browser/components/sessionstore/test/browser/browser_345898.js
: Incorrect function tested in browser/components/sessionstore/test/browser/bro...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Session Restore (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 6
Assigned To: Matt Brubeck (:mbrubeck)
:
:
Mentors:
https://mxr.mozilla.org/mozilla-centr...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-19 07:27 PDT by Alastair Robertson
Modified: 2011-05-20 10:20 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.54 KB, patch)
2011-05-19 09:14 PDT, Matt Brubeck (:mbrubeck)
paul: review+
Details | Diff | Splinter Review

Description Alastair Robertson 2011-05-19 07:27:31 PDT
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20110429 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20110429 Firefox/4.0.1

Line 77 in browser/components/sessionstore/test/browser/browser_345898.js tests getWindowValue, but the error message refers to setWindowValue.
It should probably be setWindowValue that is tested, as that function is not tested anywhere else in browser_345898.js

Reproducible: Always
Comment 1 Alastair Robertson 2011-05-19 07:40:55 PDT
Also, the tests on lines 73 and 75 are identical, which is a little odd.
Comment 2 Matt Brubeck (:mbrubeck) 2011-05-19 09:14:23 PDT
Created attachment 533667 [details] [diff] [review]
patch
Comment 3 Matt Brubeck (:mbrubeck) 2011-05-19 09:30:03 PDT
Pushed to Try: http://tbpl.mozilla.org/?tree=Try&rev=90523db6b0be
Comment 4 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2011-05-19 15:01:51 PDT
Comment on attachment 533667 [details] [diff] [review]
patch

Review of attachment 533667 [details] [diff] [review]:
-----------------------------------------------------------------

Alastair: thanks for catching that!
Matt: thanks for the quick fix :)
Comment 5 Matt Brubeck (:mbrubeck) 2011-05-19 15:19:01 PDT
Pushed to Try again, on more platforms: http://tbpl.mozilla.org/?tree=Try&rev=667f483f1b3f

This is green on all platforms; I'll push it to m-c tomorrow.
Comment 6 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2011-05-19 22:41:44 PDT
Bug 606681 is ready to go too (and might have a small context conflict). If you want to land that with this, that would be great. Otherwise I can land them.
Comment 7 Matt Brubeck (:mbrubeck) 2011-05-20 08:41:02 PDT
I can land both patches today.
Comment 8 Matt Brubeck (:mbrubeck) 2011-05-20 10:20:42 PDT
http://hg.mozilla.org/mozilla-central/rev/0cfa66a223ab

Note You need to log in before you can comment on or make changes to this bug.