Last Comment Bug 658273 - mozsqlite badly positioned in dependentlibs.list
: mozsqlite badly positioned in dependentlibs.list
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Mike Hommey [:glandium]
:
Mentors:
Depends on:
Blocks: 552864
  Show dependency treegraph
 
Reported: 2011-05-19 08:11 PDT by Mike Hommey [:glandium]
Modified: 2011-06-12 02:38 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Move sqlite before nss in dependentlibs.list (1.41 KB, patch)
2011-05-19 08:12 PDT, Mike Hommey [:glandium]
benjamin: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-05-19 08:11:27 PDT
NSS is linked against sqlite, so loading NSS libraries will require sqlite. Thus sqlite ought to appear first in dependentlibs.list, the xpcom standalone glue loading libraries in that order. It actually works without any change, but is suboptimal.
Comment 1 Mike Hommey [:glandium] 2011-05-19 08:12:37 PDT
Created attachment 533653 [details] [diff] [review]
Move sqlite before nss in dependentlibs.list
Comment 2 Zack Weinberg (:zwol) 2011-05-19 09:06:32 PDT
Doesn't nss have its own embedded copy of sqlite?
Comment 3 Mike Hommey [:glandium] 2011-05-19 10:52:53 PDT
(In reply to comment #2)
> Doesn't nss have its own embedded copy of sqlite?

Fortunately, it uses firefox's

$ readelf -d libsoftokn3.so 

Dynamic section at offset 0x2d554 contains 30 entries:
  Tag        Type                         Name/Value
 0x00000001 (NEEDED)                     Shared library: [libmozsqlite3.so]
(...)
Comment 4 Mike Hommey [:glandium] 2011-05-21 23:25:49 PDT
http://hg.mozilla.org/mozilla-central/rev/8baef6ade34e

Note You need to log in before you can comment on or make changes to this bug.