658348 - [sr] still non-Serbian strings in the Serbian localization

Status: RESOLVED FIXED

(Mozilla Localizations :: sr / Serbian, defect)

Description

[Axel Hecht [:Pike]]

gandalf ran a script looking for strings with non-cyrl entries in the sr localization, and we find at least a few strings that are definitely not Serbian.

I'll reject the signoff based on that for Firefox 5 for now.

CCing gandalf to attach the output, the script is at http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme-apps/file/trunk/scripts/check_charcodes.py

Comment 1

[Filip Miletic]

Noted.

It would help to get the report, I also have to check the source since there are severa cyrillic scripts out there and I'd like to ensure right one was used for the check.  

Fine to reject the signed-off l10n for now.

Comment 2

[Axel Hecht [:Pike]]

http://pastebin.com/xLf3SkmH is the pastebin, I don't know how long that link is gonna be up. Examples from irc:

blockAutoRefresh.label
itemBrowsingHistory.label - Pakasaritaan ti panag-browse (error: P)
deniedPortAccess.title - Ang address na ito ay may restriksyon (error: A)
fullScreenClose.tooltip - Zatvori (error: Z)
viewMenu.label - Pogledaj (error: P)

Comment 3

[Filip Miletic]

Noted the report.  

An overwhelming majority of the remarks in the report are bogus: mixed latin/cyrillic scripts are common.  Many thanks for running this script for us (sr).

Axel, what's the buzz on the accesskey correction script?  I lost the bug ID for that one.  Would be useful indeed and I'm considering using your silme repo to make my own in case you guys don't have it cooked up already.  What say you?

Comment 4

[Axel Hecht [:Pike]]

I checked my notes, no bug. Not sure if gandalf has something or can come up with something, based on his script. The idea was to look at sr beta and 1.9.2, and in all cases where there's a cyrl script accesskey in .2, replace the on in beta. Would you have cycles for that?

That said: can we get the bad strings in here fixed and landed quickly?

It turns out that our plan to not ship 4.0.x to Serbian end-users didn't work, see bug 660142, so it's really critical that we get something that's a good deal better to offer to them in 5. That's still a few weeks out, but just a few weeks. June 21st is the day when we go to build, says http://mozilla.github.com/process-releases/draft/development_specifics/#milestones, and I'd like to feel good about sr a good deal earlier.

Comment 5

[Filip Miletic]

(In reply to comment #4)
> I checked my notes, no bug. Not sure if gandalf has something or can come up

I found the request here: https://bugzilla.mozilla.org/show_bug.cgi?id=646197

I also agreed with Milos to fix up Beta (he'll lead fixing Beta) for release.   Leftover tasks are:

1) Fix this bug.
2) Have https://bugzilla.mozilla.org/show_bug.cgi?id=646197 fixed.
3) Once 1) and 2) are done, sign off on Beta.
4) Fix Aurora (I'll work on this and will backport fixes for 1) and 2))

Comment 6

[Axel Hecht [:Pike]]

great news.

Technical detail, it'd be great if the backport to aurora would be an actual hg merge, that way we get the fixes gracefully on the next cycle.

Comment 7

[Filip Miletic]

(In reply to comment #6)
> Technical detail, it'd be great if the backport to aurora would be an actual
> hg merge

How would that go?  Aren't aurora and beta two separate hg repos?  If there's a single repo that contains both then merge would be possible (provided I'm not missing a crucial detail).  Which repo should I use then?

Comment 8

[Axel Hecht [:Pike]]

beta is currently a fork of aurora, and you can basically play the reverse game that I described in https://developer.mozilla.org/En/Uplifting_a_Localization_from_central_to_aurora.

If you want help with that, I can surely do that. Or at least figure out if there are merge conflicts to resolve (which probably aren't)

Comment 9

[Axel Hecht [:Pike]]

Attachment: output of the tweaked script to filter out any strings that contain cyrl, less false positives

Comment 10

[Filip Miletic]

This is done, for both aurora and beta.  Now on to push these out to Narro.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sr/file/a1f77592b6d8
http://hg.mozilla.org/releases/l10n/mozilla-beta/sr/file/aea5970d21d8

Comment 11

[Filip Miletic]

Beta addition: 
http://hg.mozilla.org/releases/l10n/mozilla-beta/sr/rev/fa8b3b97e22c

Comment 12

[Filip Miletic]

Aurora. 

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sr/file/54c70dd90cae

Milos is preparing another patch, once done I'll apply all of these and will try to sign-off on the resulting Beta.

I trust Milos will procure it further.

Comment 13

[Filip Miletic]

Added latest translations from Milos.  If all is well, I'll sign off the result on Beta.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sr/file/ff2eacfcbfe9
http://hg.mozilla.org/releases/l10n/mozilla-beta/sr/rev/458a0105992b