windows mobile single-repo single-locale repacks broken

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: aki, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We're currently calling it via

['bash', 'scripts/scripts/l10n/nightly_mobile_repacks.sh', 'win32', 'mozilla/production_config.py', '', '6', '1']

The empty '' is supposed to be the mobile repo name.  Windows is ignoring it and assuming '6' is the mobile repo name, and breaking.

The cleanest way around this is probably to use options rather than rely on argument positioning.

A slightly less clean alternative might be to use a special word, e.g. 'NONE', and treating that as the non-mobile-repo flag.

Another option is to put the '' at the end, which will probably work, but feels a bit dirtier than the above two to me.

A fourth set of options involve changing quoting which seems like multi-platform unhappiness plus dirtiness; I'm ruling this out to start with.
(Assignee)

Comment 1

7 years ago
This workaround will go away once 5.0 ships (4.0 EOL)... we need something to work for the next 6 weeks or so.
(Assignee)

Comment 2

7 years ago
Created attachment 533842 [details] [diff] [review]
add options to nightly_mobile_repacks.sh
(Assignee)

Comment 3

7 years ago
Comment on attachment 533842 [details] [diff] [review]
add options to nightly_mobile_repacks.sh

This will require buildbotcustom/misc.py changes; getting review for the script first.
Attachment #533842 - Flags: review?(bhearsum)
Attachment #533842 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 4

7 years ago
John Ford fixed this by removing mobile repo support.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.