658377 - windows mobile single-repo single-locale repacks broken

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

We're currently calling it via

['bash', 'scripts/scripts/l10n/nightly_mobile_repacks.sh', 'win32', 'mozilla/production_config.py', '', '6', '1']

The empty '' is supposed to be the mobile repo name.  Windows is ignoring it and assuming '6' is the mobile repo name, and breaking.

The cleanest way around this is probably to use options rather than rely on argument positioning.

A slightly less clean alternative might be to use a special word, e.g. 'NONE', and treating that as the non-mobile-repo flag.

Another option is to put the '' at the end, which will probably work, but feels a bit dirtier than the above two to me.

A fourth set of options involve changing quoting which seems like multi-platform unhappiness plus dirtiness; I'm ruling this out to start with.

Comment 1

[Aki Sasaki (not active)]

This workaround will go away once 5.0 ships (4.0 EOL)... we need something to work for the next 6 weeks or so.

Comment 2

[Aki Sasaki (not active)]

Attachment: add options to nightly_mobile_repacks.sh

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 533842 [details] [diff] [review]
add options to nightly_mobile_repacks.sh

This will require buildbotcustom/misc.py changes; getting review for the script first.

Comment 4

[Aki Sasaki (not active)]

John Ford fixed this by removing mobile repo support.