658502 - SH4: use REGNUM() to access the Register number in asm_output() parameters

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P3)

Description

[Cédric VINCENT]

User-Agent:       Opera/9.80 (X11; Linux x86_64; U; en) Presto/2.7.62 Version/11.01
Build Identifier: 

This patch fixes the following compilation error(s) when NJ_VERBOSE is
defined but DEBUG isn't:
    
        In member function ‘void nanojit::Assembler::SH4_add_imm(int, nanojit::Register)’:
        error: request for member ‘n’ in ‘Rx’, which is of non-class type ‘nanojit::Register’
        ...
    
Reported and fixed by: Anandha-kumar CHINNAIYAN <[e-mail]>


Reproducible: Always

Comment 1

[Cédric VINCENT]

Attachment: SH4: use REGNUM() to access the Register number in asm_output() parameters

Comment 2

[Dan Smith]

Cédric, do you need to have this pushed?

Comment 3

[Cédric VINCENT]

(In reply to Dan Smith from comment #2)
> Cédric, do you need to have this pushed?

Yes, please.

Thanks.

Comment 4

[Dan Smith]

Rick, land Cedric's change.

Comment 5

[Rick Reitmaier]

cedric http://hg.mozilla.org/projects/nanojit-central/rev/dbdf2176179e

Comment 6

[Tamarin Bot]

changeset: 6627:3182a0d42af2
user:      =?UTF-8?q?C=C3=A9dric=20VINCENT?= <[e-mail]>
summary:   Bug 658502 SH4: use REGNUM() to access the Register number in

http://hg.mozilla.org/tamarin-redux/rev/3182a0d42af2

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.