658526 - TMFLAGS=nativebytes is broken on ARM.

Status: RESOLVED WONTFIX

(Core Graveyard :: Nanojit, defect)

Description

[Jacob Bramley [:jbramley]]

Attachment: When NJ back-tracks _nIns in the ARM back-end, back-track _nInsAfter too.

For TMFLAGS=nativebytes, asm_output asserts that _nInsAfter is after _nIns. This is quite a reasonable assumption! However, the ARM back-end includes an optimization that can fold sequential LDR/STR instructions in LDM/STM, and it back-tracks _nIn (but not _nInsAfter) when it does this.

The attached patch fixes three jit-test (-j) failures on ARM by back-tracking _nInsAfter too.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 533962 [details] [diff] [review]
When NJ back-tracks _nIns in the ARM back-end, back-track _nInsAfter too.

Review of attachment 533962 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 2

[Jacob Bramley [:jbramley]]

http://hg.mozilla.org/projects/nanojit-central/rev/070ac9dc7470

Note that I had to extend the verbose_only block (since you reviewed it) as _nInsAfter isn't defined for release builds.

Comment 3

[Nicholas Nethercote [inactive]]

Nanojit has been dead for several years. Its Bugzilla component has been moved to the graveyard (bug 984276).

I checked all the open bugs. They're all uninteresting, so I'm WONTFIXing them all. Apologies for the bugspam.