Last Comment Bug 658623 - TI: release GC lock before calling JS_ClearAllWatchPoints
: TI: release GC lock before calling JS_ClearAllWatchPoints
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem] (PTO until July 31)
:
Mentors:
Depends on:
Blocks: 619433
  Show dependency treegraph
 
Reported: 2011-05-20 12:07 PDT by Jan de Mooij [:jandem] (PTO until July 31)
Modified: 2011-05-20 13:11 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.49 KB, patch)
2011-05-20 12:10 PDT, Jan de Mooij [:jandem] (PTO until July 31)
bhackett1024: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] (PTO until July 31) 2011-05-20 12:07:39 PDT
js_DestroyContext acquires the GC lock before printing types, but we need to release it sooner to prevent a deadlock. JS_ClearAllWatchPoints can allocate shapes, needs the lock etc.

This is causing "make check" failures.
Comment 1 Jan de Mooij [:jandem] (PTO until July 31) 2011-05-20 12:10:38 PDT
Created attachment 534059 [details] [diff] [review]
Patch
Comment 2 Jan de Mooij [:jandem] (PTO until July 31) 2011-05-20 13:11:34 PDT
http://hg.mozilla.org/projects/jaegermonkey/rev/f96d9ed26fc8

Hopefully this is enough to fix |make check|.

Note You need to log in before you can comment on or make changes to this bug.