The default bug view has changed. See this FAQ.

TI: release GC lock before calling JS_ClearAllWatchPoints

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
js_DestroyContext acquires the GC lock before printing types, but we need to release it sooner to prevent a deadlock. JS_ClearAllWatchPoints can allocate shapes, needs the lock etc.

This is causing "make check" failures.
(Assignee)

Comment 1

6 years ago
Created attachment 534059 [details] [diff] [review]
Patch
Attachment #534059 - Flags: review?(bhackett1024)
Attachment #534059 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/projects/jaegermonkey/rev/f96d9ed26fc8

Hopefully this is enough to fix |make check|.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.