658644 - ccache is off on linux 64 builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

I noticed that 32 bit builds use ccache, but 64 bit don't.

Comment 1

[Chris AtLee [:catlee]]

Attachment: Enable ccache on linux64

this will have to wait until next week to deploy

Comment 2

[Chris AtLee [:catlee]]

mozconfigs also need updating

Comment 3

[Armen [:armenzg]]

Please re-assign if you see fit.

Comment 4

[Chris Cooper [:coop] (he/him)]

Attachment: Add ccache to linux64 mozconfigs

Decided to help catlee out. Hoping to get this landed this week instead.

A big patch, but it's just adding ccache to the options on all the linux64 mozconfigs.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 535392 [details] [diff] [review]
Add ccache to linux64 mozconfigs

I don't think this is the right way to turn it on. On 32-bit Linux we use:
REAL_CC=/tools/gcc/bin/gcc
REAL_CXX=/tools/gcc/bin/g++

CC="ccache $REAL_CC"
CXX="ccache $REAL_CXX"

We don't use ccache for release builds for 32-bit, so let's stay consistent here.

I think you missed a few mozconfigs too: eg, mozilla-1.9.2 nightly/debug.

Comment 7

[Chris Cooper [:coop] (he/him)]

Attachment: Add ccache to linux64 mozconfigs, v2

OK, I think I've unraveled this now.

1.9.1 and 1.9.2 need the |CC="ccache $REAL_CC"| style declaration, everything else needs |ac_add_options --with-ccache=/usr/bin/ccache|.

Also, we don't use ccache for releases or debug builds on 32bit linux, so don't turn it on for 64bit either.

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 535451 [details] [diff] [review]
Add ccache to linux64 mozconfigs, v2

http://hg.mozilla.org/build/buildbot-configs/rev/2c54d5d80de9

Comment 9

[Chris Cooper [:coop] (he/him)]

Merged to production today.