Closed Bug 658726 Opened 13 years ago Closed 13 years ago

20110505 build broke some toolbar background when persona theme is enable

Categories

(Firefox :: Tabbed Browser, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: dindog, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0

I narror it to \omni.jar\chrome\browser\content\browser\tabbrowser.xml
there is only on difference between 20110504 and 20110505 build of this file:
2437a2438,2442
> 
>           this.style.backgroundColor =
>             Services.prefs.getBoolPref("browser.display.use_system_colors") ?
>               "-moz-default-background-color" :
>               Services.prefs.getCharPref("browser.display.background_color");

attachment is a picture show a on top search toolbar background change in two build.

Reproducible: Always
and here is the userchrome.js I use to move the findbar on top of the page:

XPCOMUtils.defineLazyGetter(window, "gFindBar", function() {
  let XULNS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";
  let findbar = document.createElementNS(XULNS, "findbar");
  findbar.setAttribute("browserid", "content");
  findbar.id = "FindToolbar";
  let panel = getBrowser().mPanelContainer;
  panel.parentNode.insertBefore(findbar, panel);

  // Force a style flush to ensure that our binding is attached.
  findbar.clientTop;
  window.gFindBarInitialized = true;
  return findbar;
});
Version: unspecified → 4.0 Branch
Does it also happen without this code or in Safe Mode (http://support.mozilla.com/en-US/kb/Safe+Mode)?
(In reply to comment #3)
> Does it also happen without this code or in Safe Mode
> (http://support.mozilla.com/en-US/kb/Safe+Mode)?

in safe-mode, I won't have that findbar.... it's a userchrome.js move the findbar from bottom to top of the page.

come to this, we now has Tab On Top, will the UI team consider also let the findbar on top too? IE, opera's findbar is on top from the very beginning
Please answer my question if this problem also occurs without that extra code running.
(In reply to comment #5)
> Please answer my question if this problem also occurs without that extra
> code running.

no. in safe-mode, the findbar is at the bottom of page and backgroup is normal
Something I missed to ask, can you please give us the changesets from the two builds you have mentioned in comment 0? You can find those in about:buildconfig.
(In reply to comment #7)
> Something I missed to ask, can you please give us the changesets from the
> two builds you have mentioned in comment 0? You can find those in
> about:buildconfig.

from mozillazine forum:
20110505 31879b88cc82
20110504 c3c4c902e9cd
Is that what you mean?
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c3c4c902e9cd&tochange=31879b88cc82

From the list of check-ins that day the only facing bug for me is bug 558585. It's patch contains the changes mentioned in comment 0. Dao, could you have a look please?
Blocks: 558585
Keywords: regression
Version: 4.0 Branch → Trunk
(In reply to comment #2)
> and here is the userchrome.js I use to move the findbar on top of the page:
> 
> XPCOMUtils.defineLazyGetter(window, "gFindBar", function() {
>   let XULNS =
> "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";
>   let findbar = document.createElementNS(XULNS, "findbar");
>   findbar.setAttribute("browserid", "content");
>   findbar.id = "FindToolbar";
>   let panel = getBrowser().mPanelContainer;
>   panel.parentNode.insertBefore(findbar, panel);
> 
>   // Force a style flush to ensure that our binding is attached.
>   findbar.clientTop;
>   window.gFindBarInitialized = true;
>   return findbar;
> });

If you hack software like this, you need to be aware that your hack could break any time as the software changes.
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: