Closed
Bug 658740
Opened 13 years ago
Closed 13 years ago
Test Pilot error logger throws exception
Categories
(Mozilla Labs Graveyard :: Test Pilot, defect, P2)
Mozilla Labs Graveyard
Test Pilot
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: jono, Unassigned)
Details
Attachments
(1 file)
|
7.18 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
I heard you like errors in your error handling code... in remote-experiment-loader.js it calls _logger.warn(e) but it should be doing _logger.warn(errStr).
Priority: -- → P2
Whiteboard: needs-integration
Target Milestone: --- → 1.2
This patch fixes the error handling code problem -- it also fixes some minor variable scope issues and handles a case where a callback is undefined, all of which are too small to be worth filing their own bugs for.
Attachment #534192 -
Flags: review?(dtownsend)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 534192 [details] [diff] [review] Patch against mozilla-central fixing the problem Review of attachment 534192 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #534192 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 3•13 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/705dc68a1cf9
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: needs-integration
|
Assignee | |
Updated•8 years ago
|
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•