658754 - 5.0 beta whatsnew page layout issues

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect, P1)

Description

[Justin Scott [:fligtar]]

This is what my Firefox 5 beta whatsnew page looks like: http://grab.by/abqX

I don't know how it's supposed to look but 2 things seem wrong:
1. The Adobe flash warning is hard to read with the background image

2. There's a tooltip trail showing the Feedback button but no text.

Comment 1

[Anthony Ricaud (:rik)]

Steven, what do you think?

Comment 2

[Steven Garrity [:sgarrity]]

Ah, we've got some messy bug dependencies here. Bug 651958, (r89068 in particular) adds a new style to the flash warning, but is held back by a delay on the 4.0 whatsnew page (Bug 649680).

We could do a few things:

1. Push the flash warning update functionality, but roll-back the 4.0 pages that use it
2. Update the 5.0 pages not to use the flash warning

James, have a preference?

Comment 3

[John Slater]

I'm fine taking the flash warning off the 5.0 pages for now. Obviously we should get the larger issue fixed before the 5.0 launch though (and ideally as soon as possible).

Comment 4

[Steven Garrity [:sgarrity]]

I've made a minor change that disables the Flash detection on the 5.0 page. When Bug 651958 rolls out, we can revert this change and we'll be all set across 3.6/4/5 pages.

Done in trunk in r89450. Merged to stage in r89452.

Comment 5

[raymond [:retornam] (inactive)]

qa-verified-trunk http://www-trunk.stage.mozilla.com/en-US/firefox/5.0beta/firstrun/index.html

Comment 6

[James Long (:jlongster)]

pushed to production r89665