Last Comment Bug 658779 - Addons are no longer on AMO
: Addons are no longer on AMO
Status: RESOLVED FIXED
:
Product: addons.mozilla.org Graveyard
Classification: Graveyard
Component: Public Pages (show other bugs)
: unspecified
: All All
: P1 normal
: 6.0.11
Assigned To: Jeff Balogh (:jbalogh)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-21 06:56 PDT by Mike Kaply [:mkaply]
Modified: 2016-02-04 14:51 PST (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Comment 1 User image Wil Clouser [:clouserw] 2011-05-21 09:31:12 PDT
I suspect they've ended up in guarded-addons.  -> jbalogh to investigate and fix
Comment 3 User image Mike Kaply [:mkaply] 2011-05-23 13:33:07 PDT
We can't be the only people this happened to.

Any updates on this? These are two of our most popular addons.
Comment 4 User image Jeff Balogh (:jbalogh) 2011-05-23 16:58:18 PDT
2 : from addons.models import Addon
3 : a = Addon.objects.get(id=11160)
4 : a.current_version.all_files
5 : a.current_version
6 : f = a.current_version.all_files[0]
7 : f.unhide_disabled_file()
8 : f.copy_to_mirror()
9 : a = Addon.objects.get(id=13703)
10: a.current_version
11: f = a.current_version.all_files[0]
12: f.unhide_disabled_file()
13: f.copy_to_mirror()
14: a = Addon.objects.get(id=12518)
15: f = a.current_version.all_files[0]
16: f.unhide_disabled_file()
17: f.copy_to_mirror()
18: _ip.magic("hist ")
Comment 5 User image Mike Kaply [:mkaply] 2011-05-23 18:06:54 PDT
OK, they're back.

So, why did they disappear?

And why can't I view the validation results from the 4.0->5.0 thing?
Comment 6 User image Jeff Balogh (:jbalogh) 2011-05-24 15:22:26 PDT
https://github.com/jbalogh/zamboni/commit/3c2b3cf
Comment 7 User image Mike Kaply [:mkaply] 2011-05-24 15:26:49 PDT
I still don't see any answers to my question.

And this comment:

> Files are getting stuck in /guarded-addons for some reason

Doesn't help.

Did these files get stuck in guarded because of the 4.0->5.0 version bump?

Why don't the validation links work?

Why are you working around the problem instead of figuring out why it broke?
Comment 8 User image Wil Clouser [:clouserw] 2011-05-24 15:34:31 PDT
We've been seeing add-ons stuck in /guarded-addons for the past few weeks.  We haven't determined a cause or a pattern but it doesn't have to do with the 4.0->5.0 version bump.

If the validator wasn't expecting to find your add-ons in /guarded-addons when it ran, the links will be broken.

The patch above fixes the problem and adds additional logging so we can determine what is causing it.  As I mentioned, we haven't seen a pattern yet.

Thanks for the fix, jbalogh.
Comment 9 User image Mike Kaply [:mkaply] 2011-05-24 15:45:29 PDT
Interesting. So it was a chicken and egg problem.

I thought they were not available because of the version bump.

But it turns out they failed to get the version bump because they weren't available.

Doh!

Thanks for the explanation.

Note You need to log in before you can comment on or make changes to this bug.