Text in plugins (PDF and JAVA) is transparent, showing content behind the browser window, if a sidebar is displayed in Aero glass

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Rakshith, Assigned: jimm)

Tracking

({regression})

Trunk
x86
Windows 7
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110521 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110521 Firefox/6.0a1

This Flaw occurs when Using the shortcut ctrl+B to open bookmark sidebar hence causing the pdf file to adjust size to fit in the space which as a result causes the text to become transparent. Its Lasting affect varies.

Reproducible: Always

Steps to Reproduce:
1.Open a PDF document in Firefox
2.open bookmark sidebar In the (PDF) opened Page using the shortcut. But since shortcuts dont work in pdf document as per bug here https://bugzilla.mozilla.org/show_bug.cgi?id=78414   ,Click on the location bar and use ctrl+B to open bookmark sidebar
3.Notice the Text color change in the pdf file.

Actual Results:  
The PDF Text Color changes and takes the desktop background color as a replacement. (This only could happen in windows 7/vista as it has aero enabled)

Expected Results:  
text color must not change.

Lasting affect varies though
(Reporter)

Comment 1

6 years ago
Created attachment 534231 [details]
See the rendered color of text when opened bookmark sidebar.
Confirming.  This also happens with the JAVA plug-in.  This is a recent regression, I believe from the fix for bug 633282.  I am doing a bisect now to confirm.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Summary: Text In PDF documents opened in Firefox Tend to Become Transparent adopting the desktop background color as a fill in color over the text → Text In plugins (PDF and JAVA) is Transparent if sidbar is present in a maximized window
Summary: Text In plugins (PDF and JAVA) is Transparent if sidbar is present in a maximized window → Text In plugins (PDF and JAVA) is Transparent if sidebar is present in a maximized window
Changing the Summary again.  It seems that although the JAVA case I had was only reproducible with a maximized window, for PDF files I see this for non-maximized windows as well.
Summary: Text In plugins (PDF and JAVA) is Transparent if sidebar is present in a maximized window → Text in plugins (PDF and JAVA) is transparent, showing content behind the browser window, if a sidebar is displayed in Aero glass

Updated

6 years ago
Version: unspecified → Trunk
Blocks: 633282
Component: General → Layout
Product: Firefox → Core
QA Contact: general → layout
HG bisect said:

Due to skipped revisions, the first bad revision could be any of:
changeset:   69172:b9f2ad2a6954
user:        Jim Mathies <jmathies@mozilla.com>
date:        Fri May 13 11:40:46 2011 -0500
summary:     Bug 633282 - Accumulate exclude glass regions during painting and u
pdate the widget opaque region info. r=roc.

changeset:   69173:7cad85d7872b
user:        Jim Mathies <jmathies@mozilla.com>
date:        Fri May 13 11:40:46 2011 -0500
summary:     Bug 633282 - Change up widget's UpdateTransparentRegion to UpdateOp
aqueRegion. r=roc.
(Assignee)

Comment 5

6 years ago
Created attachment 534288 [details]
bookmarks + pdf

Odd, the area matches that of the width of the sidebar.
Assignee: nobody → jmathies
(Assignee)

Comment 6

6 years ago
Created attachment 534306 [details] [diff] [review]
fix

mRect has the offset from the parent, so I'm adding that in twice. What I wanted was the size from mRect positioned according to the offset from the root frame. This is a bit fugly but it fixes the bug.
Attachment #534306 - Flags: review?(roc)
(Assignee)

Comment 7

6 years ago
Created attachment 534307 [details] [diff] [review]
fix

- without the debug printfs.
Attachment #534306 - Attachment is obsolete: true
Attachment #534306 - Flags: review?(roc)
Attachment #534307 - Flags: review?(roc)
Comment on attachment 534307 [details] [diff] [review]
fix

Review of attachment 534307 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/base/src/nsBoxFrame.cpp
@@ -1303,5 @@
>    // in calculating glass margins on Windows.
>    if (GetContent()->IsXUL()) {
>        const nsStyleDisplay* styles = mStyleContext->GetStyleDisplay();
>        if (styles && styles->mAppearance == NS_THEME_WIN_EXCLUDE_GLASS) {
> -        nsRect rect = mRect + aBuilder->ToReferenceFrame(this);

Just make it mRect + aBuilderToReferenceFrame(GetParent())?
(Assignee)

Comment 9

6 years ago
(In reply to comment #8)
> Comment on attachment 534307 [details] [diff] [review] [review]
> fix
> 
> Review of attachment 534307 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: layout/xul/base/src/nsBoxFrame.cpp
> @@ -1303,5 @@
> >    // in calculating glass margins on Windows.
> >    if (GetContent()->IsXUL()) {
> >        const nsStyleDisplay* styles = mStyleContext->GetStyleDisplay();
> >        if (styles && styles->mAppearance == NS_THEME_WIN_EXCLUDE_GLASS) {
> > -        nsRect rect = mRect + aBuilder->ToReferenceFrame(this);
> 
> Just make it mRect + aBuilderToReferenceFrame(GetParent())?

Ok, I actually thought of that one, but was wondering if ToReferenceFrame was guaranteed to always returned the top level root frame. I'm assuming it does based on your feedback.
It does when we're painting the window.

Updated

6 years ago
Duplicate of this bug: 658940
(Assignee)

Comment 12

6 years ago
Created attachment 534396 [details] [diff] [review]
fix
Attachment #534307 - Attachment is obsolete: true
Attachment #534307 - Flags: review?(roc)
Attachment #534396 - Flags: review?(roc)
Comment on attachment 534396 [details] [diff] [review]
fix

Review of attachment 534396 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #534396 - Flags: review?(roc) → review+
Can we get this checked in today so it makes it in time for the merge to Aurora?
(Assignee)

Comment 15

6 years ago
http://hg.mozilla.org/mozilla-central/rev/d04cae0f5d22
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.