658785 - Text in plugins (PDF and JAVA) is transparent, showing content behind the browser window, if a sidebar is displayed in Aero glass

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Rakshith]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110521 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110521 Firefox/6.0a1

This Flaw occurs when Using the shortcut ctrl+B to open bookmark sidebar hence causing the pdf file to adjust size to fit in the space which as a result causes the text to become transparent. Its Lasting affect varies.

Reproducible: Always

Steps to Reproduce:
1.Open a PDF document in Firefox
2.open bookmark sidebar In the (PDF) opened Page using the shortcut. But since shortcuts dont work in pdf document as per bug here https://bugzilla.mozilla.org/show_bug.cgi?id=78414   ,Click on the location bar and use ctrl+B to open bookmark sidebar
3.Notice the Text color change in the pdf file.

Actual Results:  
The PDF Text Color changes and takes the desktop background color as a replacement. (This only could happen in windows 7/vista as it has aero enabled)

Expected Results:  
text color must not change.

Lasting affect varies though

Comment 1

[Rakshith]

Attachment: See the rendered color of text when opened bookmark sidebar.

Comment 2

[Bill Gianopoulos [:WG9s]]

Confirming.  This also happens with the JAVA plug-in.  This is a recent regression, I believe from the fix for bug 633282.  I am doing a bisect now to confirm.

Comment 3

[Bill Gianopoulos [:WG9s]]

Changing the Summary again.  It seems that although the JAVA case I had was only reproducible with a maximized window, for PDF files I see this for non-maximized windows as well.

Comment 4

[Bill Gianopoulos [:WG9s]]

HG bisect said:

Due to skipped revisions, the first bad revision could be any of:
changeset:   69172:b9f2ad2a6954
user:        Jim Mathies <[e-mail]>
date:        Fri May 13 11:40:46 2011 -0500
summary:     Bug 633282 - Accumulate exclude glass regions during painting and u
pdate the widget opaque region info. r=roc.

changeset:   69173:7cad85d7872b
user:        Jim Mathies <[e-mail]>
date:        Fri May 13 11:40:46 2011 -0500
summary:     Bug 633282 - Change up widget's UpdateTransparentRegion to UpdateOp
aqueRegion. r=roc.

Comment 5

[Jim Mathies [:jimm]]

Attachment: bookmarks + pdf

Odd, the area matches that of the width of the sidebar.

Comment 6

[Jim Mathies [:jimm]]

Attachment: fix

mRect has the offset from the parent, so I'm adding that in twice. What I wanted was the size from mRect positioned according to the offset from the root frame. This is a bit fugly but it fixes the bug.

Comment 7

[Jim Mathies [:jimm]]

Attachment: fix

- without the debug printfs.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 534307 [details] [diff] [review]
fix

Review of attachment 534307 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/base/src/nsBoxFrame.cpp
@@ -1303,5 @@
>    // in calculating glass margins on Windows.
>    if (GetContent()->IsXUL()) {
>        const nsStyleDisplay* styles = mStyleContext->GetStyleDisplay();
>        if (styles && styles->mAppearance == NS_THEME_WIN_EXCLUDE_GLASS) {
> -        nsRect rect = mRect + aBuilder->ToReferenceFrame(this);

Just make it mRect + aBuilderToReferenceFrame(GetParent())?

Comment 9

[Jim Mathies [:jimm]]

(In reply to comment #8)
> Comment on attachment 534307 [details] [diff] [review] [review]
> fix
> 
> Review of attachment 534307 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: layout/xul/base/src/nsBoxFrame.cpp
> @@ -1303,5 @@
> >    // in calculating glass margins on Windows.
> >    if (GetContent()->IsXUL()) {
> >        const nsStyleDisplay* styles = mStyleContext->GetStyleDisplay();
> >        if (styles && styles->mAppearance == NS_THEME_WIN_EXCLUDE_GLASS) {
> > -        nsRect rect = mRect + aBuilder->ToReferenceFrame(this);
> 
> Just make it mRect + aBuilderToReferenceFrame(GetParent())?

Ok, I actually thought of that one, but was wondering if ToReferenceFrame was guaranteed to always returned the top level root frame. I'm assuming it does based on your feedback.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It does when we're painting the window.

Comment 12

[Jim Mathies [:jimm]]

Attachment: fix

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 534396 [details] [diff] [review]
fix

Review of attachment 534396 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 14

[Bill Gianopoulos [:WG9s]]

Can we get this checked in today so it makes it in time for the merge to Aurora?

Comment 15

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/d04cae0f5d22