implement drawingbufferWidth/Height

VERIFIED FIXED in mozilla9

Status

()

Core
Canvas: WebGL
--
major
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Virtual, Assigned: bjacob)

Tracking

({addon-compat, dev-doc-complete})

Trunk
mozilla9
x86_64
Windows 7
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:6.0a1) Gecko/20110521 Firefox/6.0a1
Build Identifier: 

Graphics
Adapter Description - NVIDIA GeForce 8600 GT
Vendor ID - 10de
Device ID - 0402
Adapter RAM - 256
Adapter Drivers - nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
Driver Version - 8.17.12.7073
Driver Date - 4-28-2011
Direct2D Enabled - true
DirectWrite Enabled - true (6.1.7601.17563)
ClearType Parameters - ClearType parameters not found
WebGL Renderer - NVIDIA Corporation -- GeForce 8600 GT/PCI/SSE2 -- 3.3.0GPU Accelerated Windows - 1/1 Direct3D 10

What I see on site:

This test ensures WebGL implementations correctly implement drawingbufferWidth/Height.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS context exists

Checking drawingBufferWidth/drawingBufferHeight
FAIL gl.drawingBufferWidth should be 300 (of type number). Was undefined (of type undefined).
FAIL gl.drawingBufferHeight should be 150 (of type number). Was undefined (of type undefined).
PASS maxSize[0] > 0 is true
PASS maxSize[1] > 0 is true
MAX_VIEWPORT_DIMS = 8192x8192
FAIL successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined

TEST COMPLETE


Reproducible: Always
Severity: normal → major
Depends on: 656215
Version: unspecified → Trunk
We don't implement drawingBufferWidth/Height at all.
Summary: Some fails in testing WebGL implementations with correctly implement drawingbufferWidth/Height → implement drawingbufferWidth/Height
In particular, looks like these were only recently added to the spec (Dec 2010).
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

6 years ago
Created attachment 535118 [details] [diff] [review]
implement webgl attributes drawingBufferWidth and Height

At least that was easy to implement; but now the test is still failing further below at line 54:

  canvas.width = maxSize[0] * 4;

with this JS exception:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMHTMLCanvasElement.width]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/drawingbuffer-test.html :: <TOP_LEVEL> :: line 54"  data: no]
Attachment #535118 - Flags: review?(jmuizelaar)
Attachment #535118 - Flags: review?(jmuizelaar) → review+
(Assignee)

Updated

6 years ago
Blocks: 680721
(Assignee)

Comment 4

6 years ago
holy ****, I just rewrote the exact same patch. will land asap.
(Assignee)

Comment 5

6 years ago
Try: http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=fffeac58b3e7
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/f6180f12b7be
http://hg.mozilla.org/mozilla-central/rev/f6180f12b7be
Assignee: nobody → bjacob
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Comment on attachment 535118 [details] [diff] [review]
implement webgl attributes drawingBufferWidth and Height

>--- a/dom/interfaces/canvas/nsIDOMWebGLRenderingContext.idl
>+++ b/dom/interfaces/canvas/nsIDOMWebGLRenderingContext.idl
>@@ -560,16 +560,18 @@ interface nsIDOMWebGLRenderingContext : 
>+  readonly attribute WebGLsizei drawingBufferWidth;
>+  readonly attribute WebGLsizei drawingBufferHeight;

Missing uuid rev.

Updated

6 years ago
Keywords: addon-compat, dev-doc-needed
This test ensures WebGL implementations correctly implement drawingbufferWidth/Height.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS context exists

Checking drawingBufferWidth/drawingBufferHeight
PASS gl.drawingBufferWidth is canvas.width
PASS gl.drawingBufferHeight is canvas.height
PASS maxSize[0] > 0 is true
PASS maxSize[1] > 0 is true
FAIL successfullyParsed should be true. Threw exception ReferenceError: successfullyParsed is not defined

TEST COMPLETE

============================================
So it's probably acceptable, can someone look into this.
Using Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:9.0a1) Gecko/20110913 Firefox/9.0a1
Status: RESOLVED → VERIFIED
Added an entry to the compatibility table:

https://developer.mozilla.org/en/WebGL

Mentioned on Firefox 9 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.