Last Comment Bug 658876 - nsHttpChannel.mAsyncOpenTime should be set after mLoadGroup->AddRequest
: nsHttpChannel.mAsyncOpenTime should be set after mLoadGroup->AddRequest
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Honza Bambas (:mayhemer)
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on: 576006
Blocks: 658894
  Show dependency treegraph
 
Reported: 2011-05-22 07:10 PDT by Honza Bambas (:mayhemer)
Modified: 2011-05-23 11:04 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 [Check in comment 3] (1.63 KB, patch)
2011-05-22 07:19 PDT, Honza Bambas (:mayhemer)
cbiesinger: review+
Details | Diff | Splinter Review

Description Honza Bambas (:mayhemer) 2011-05-22 07:10:15 PDT
If some observer called from AsyncOpen set the timingEnabled flag, we don't track AsyncOpen call time.  Proposing to move mAsyncOpenTime assignment after we add the request to its load group.
Comment 1 Honza Bambas (:mayhemer) 2011-05-22 07:19:25 PDT
Created attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]
Comment 2 Christian :Biesinger (don't email me, ping me on IRC) 2011-05-22 09:43:23 PDT
Comment on attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]

Please add a comment explaining why this is after the AddRequest call
Comment 3 Honza Bambas (:mayhemer) 2011-05-23 07:44:24 PDT
Comment on attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]

http://hg.mozilla.org/mozilla-central/rev/1027e54104df
Comment 4 Honza Bambas (:mayhemer) 2011-05-23 07:45:07 PDT
Review comments addressed in the push directly.

Note You need to log in before you can comment on or make changes to this bug.