Closed Bug 658876 Opened 13 years ago Closed 13 years ago

nsHttpChannel.mAsyncOpenTime should be set after mLoadGroup->AddRequest

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file)

v1 [Check in comment 3]
1.63 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review 
If some observer called from AsyncOpen set the timingEnabled flag, we don't track AsyncOpen call time.  Proposing to move mAsyncOpenTime assignment after we add the request to its load group.
Depends on: 576006
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED

        Attachment #534294 -
        Flags: review?(cbiesinger)

    
    

    
  
Comment on attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]

Please add a comment explaining why this is after the AddRequest call

        Attachment #534294 -
        Flags: review?(cbiesinger) → review+

    
    

    
  
Comment on attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]

http://hg.mozilla.org/mozilla-central/rev/1027e54104df

        Attachment #534294 -
        Attachment description: v1 → v1 [Check in comment 3]

    
    

    
  
Review comments addressed in the push directly.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Blocks: 658894

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: