nsHttpChannel.mAsyncOpenTime should be set after mLoadGroup->AddRequest

RESOLVED FIXED

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
If some observer called from AsyncOpen set the timingEnabled flag, we don't track AsyncOpen call time.  Proposing to move mAsyncOpenTime assignment after we add the request to its load group.
(Assignee)

Updated

6 years ago
Depends on: 576006
(Assignee)

Comment 1

6 years ago
Created attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #534294 - Flags: review?(cbiesinger)
Comment on attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]

Please add a comment explaining why this is after the AddRequest call
Attachment #534294 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 534294 [details] [diff] [review]
v1 [Check in comment 3]

http://hg.mozilla.org/mozilla-central/rev/1027e54104df
Attachment #534294 - Attachment description: v1 → v1 [Check in comment 3]
(Assignee)

Comment 4

6 years ago
Review comments addressed in the push directly.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Blocks: 658894
You need to log in before you can comment on or make changes to this bug.