658928 - Use the xpcshell manifest to disable tests

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

xpcshell manifests (bug 616999) allow us to disable tests based on platform and other things like whether we're in a debug build or not, e.g.:

[test_foo.js]
skip-if.os = mac
skip-if.config = debug

That means we can get rid of our custom hackery in head_appinfo.js.in. \o/

Comment 1

[Richard Newman [:rnewman]]

That makes me so happy.

Comment 2

[Philipp von Weitershausen [:philikon]]

... or how I stopped worrying and love the manifests.

Comment 3

[(not currently active) Ted Mielczarek]

If there are conditions that you need that the manifest won't let you test, file a bug in Testing : XPCshell and we'll add the required functionality.

Comment 4

[(not currently active) Ted Mielczarek]

These should be a lot more usable now. Let me know if you hit any issues.

Comment 5

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 544410 [details] [diff] [review]
v1

Review of attachment 544410 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. A try build might be good, even considering s-c, because a try build will be a clean build... I'll settle for non-Windows platforms, though.

Comment 7

[Philipp von Weitershausen [:philikon]]

Try build: http://tbpl.mozilla.org/?tree=Try&rev=1817a58600f9

Comment 8

[Philipp von Weitershausen [:philikon]]

(In reply to comment #4)
> These should be a lot more usable now. Let me know if you hit any issues.

Thanks Ted. This works great for us now, although it would be nice if there was a way to bypass skip-if conditions, e.g. via environment variables. See bug 669821.

Comment 9

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/services-central/rev/94fe1ee0d02c

Comment 10

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/94fe1ee0d02c