Closed Bug 658939 Opened 9 years ago Closed 9 years ago

e10s HTTP: not calling on-examine-response observers

Categories

(Core :: Networking: HTTP, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ugzbay, Assigned: jduell.mcbugs)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b13pre) Gecko/20110318 Firefox/4.0b13pre
Build Identifier: 

One line fix.

Reproducible: Always
Attached patch fixSplinter Review
Assignee: nobody → jduell.mcbugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #534364 - Flags: review?(cbiesinger)
Comment on attachment 534364 [details] [diff] [review]
fix

seems fine. child listeners won't be able to mess with the cookie header and have it take effect but that seems fine.
Attachment #534364 - Flags: review?(cbiesinger) → review+
cc-ing cookies "usual suspects" in case they have opinions:

> child listeners won't be able to mess with the cookie header and have 
> it take effect but that seems fine

Some more details.  In the parent, on-examine-response observers are called before cookies get parsed, so they can remove/tweak cookies.  This patch calls on-examine-response observers in the child after that, so they wouldn't have the same opportunity.

This could in theory be fixed, by sending IPC traffic and having the child notify the observers (and ship back any channel header changes made back to the parent) before parsing the cookies.  The cost would be an IPDL round trip, which sucks a bit given that this is the uncommon case, but we'd incur it for all traffic.
http://hg.mozilla.org/mozilla-central/rev/5ea92972f52c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 646373
You need to log in before you can comment on or make changes to this bug.