659293 - Hidden lines still have hover tooltips

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect, P1)

Description

[Justin Lebar (not reading bugmail)]

Create a graph, hide a line, and then hover over where the line was.  You still get a tooltip, but you shouldn't.

Comment 1

[Robert Helmer [:rhelmer]]

Fixed:
https://github.com/rhelmer/graphs/commit/adf9ed62d7801c4c83828fbd1cf3bfb42f357275

Pushed to staging:
http://graphs.allizom.org

Going to hold off filing a bug to get this pushed to production, since I expect to pick up some more fixes over the next few days.

Comment 2

[Justin Lebar (not reading bugmail)]

This doesn't work right.  If I make the second line invisible, I don't get any tooltips when I hover over the first one.  If I make the first line invisible, I still get hover tooltips over both lines.

Comment 3

[Robert Helmer [:rhelmer]]

Yikes, thanks. Yeah I need to test that better this time.

Comment 4

[Robert Helmer [:rhelmer]]

Backed out the previous change, and committed this instead:
https://github.com/rhelmer/graphs/commit/b1926f704fa3841659ec7b9aa93ee32c69983ff1

Pushed to staging:
http://graphs.allizom.org

The previous change disabled hover/click for the whole plot, not sure what I was thinking but I see how I thought it tested good.

I don't see a very nice way to disable things like hover, click etc. per flot other than ignoring in the onplotclick/onhoverclick handler, or just removing the data for the invisible series. This commit does the latter.

Thanks for catching that jlebar, hopefully this resolves the problem.

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to comment #4)
> I don't see a very nice way to disable things like hover, click etc. per
> flot

Meant to say "per series in flot" ^