659346 - Custom tabs in addon manager can not be opened now

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[Yakove]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110524 Firefox/6.0a1
Build Identifier: 

Custom tabs, such as User styles (created by Stylish addon) or User scripts (Greasemonkey) do not respond when clicking on it. It's a regression since few last builds

Reproducible: Always

Steps to Reproduce:
1. Create new profile
2. Go to https://arantius.com/misc/gm-nightly/ and setup latest dev build of Greasemonkey (compatible with FF6), restart browser
3. Go to userscripts.org and install one or more scripts
4. Now go to addon manager. There's a new item - User Scripts
5. Click on this item

Actual Results:  
Nothing happens

Expected Results:  
Should open a tab with the list of installed userscripts

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Do you see any failures in the error console? Also can you please check the builds from the last days which introduced this regression? The changeset ids from about:buildconfig would be kinda helpful.

Comment 2

[Dave Townsend [:mossop]]

Sounds like that add-on needs to be updated from changes in bug 595848.

I wasn't expecting that on having any breaking effect on add-ons though, are there any messages in the error console?

Comment 3

[Yakove]

In error console errors like that:

Error: aAddon is null
Source File: chrome://greasemonkey/content/addons4-overlay.js
Line: 78

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As Dave mentioned could be the reason of landing bug 595848. I would like to track all those regression from it, so I will add the dependency.

Comment 5

[Thomas Ahlblom]

Tracked down with GNU/Linux:

Last good nightly: 2011-05-20 First bad nightly: 2011-05-21

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2e0e36b0feae&tochange=21c304c5f351


The first bad revision is:
changeset:   69794:7d17e8e3c617
user:        Dave Townsend <[e-mail]>
date:        Fri May 20 10:36:28 2011 -0700
summary:     Bug 595848: Dynamically generate the list of categories. r=Unfocused

Comment 6

[Dave Townsend [:mossop]]

Yes, there are a few requirements for add-ons doing this sort of thing. I should have some docs with the details on it done sometime tomorrow.

Comment 7

[Dave Townsend [:mossop]]

The blog post is up now: http://www.oxymoronical.com/blog/2011/05/Creating-custom-add-on-types-just-got-easier

For greasemonkey the specific issue is that they must now register their new add-on type. They should be able to do this without breaking backwards compatibility.

Comment 8

[Vlad [QA]]

Reporter, do you have anything new about this issue?

Comment 9

[Yakove]

Now we have fixed versions of Stylish and Scriptish, waiting for Greasemonkey.

This is not Firefox issue, maybe WONTFIX

Comment 10

[Vlad [QA]]

Considering comment9, can you please change the status to Resolved Invalid.
thx

Comment 11

[smacharia8]

(In reply to comment #9)
> Now we have fixed versions of Stylish and Scriptish, waiting for
> Greasemonkey.
> 
> This is not Firefox issue, maybe WONTFIX

Can you direct me to new scriptish ver? Can't find it at moz-addons nor github

Comment 12

[Yakove]

(In reply to comment #11)

> Can you direct me to new scriptish ver? Can't find it at moz-addons nor
> github

https://github.com/downloads/erikvold/scriptish/scriptish-0.1.1.xpi

Comment 13

[smacharia8]

Thanks Yakove.

Update on Greasemonkey: v0.9.6 was released yesterday and claims to have fixed the bug for FF5.0. I can't verify because I run Aurora (6.0a2) and Nightly on which the addon still malfunctions; Scriptish on the other hand is compatible with all versions.

Again, this is just an update on the Greasemonkey team's progress.