Pressing Create Profile gives JavaScript error in console

VERIFIED FIXED

Status

VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: bugzilla, Assigned: bugs)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
If you start the profile manager with the console and javascript strict option 
on, when you press the Create Profile.. button the console says:

JavaScript error:
chrome://global/content/wizardHandlerSet.js line 157: controls has no properties

Comment 1

18 years ago
Created attachment 23831 [details] [diff] [review]
workaround for js error in wizards
if ("controls" in document) {

}

is better than if (document.controls) and avoids a js warning

otherwise, a=ben@netscape.com

Comment 3

18 years ago
Created attachment 24620 [details] [diff] [review]
Patch with Ben's suggestion

Comment 4

18 years ago
Modified patch checked in.  Thanks.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
That last patch has tabs where it should not.

Super-style nit: doesn't if ('controls' in doc) set the property name off from
other (non-property-name) strings, which normally use "" rather than ''?  '' is
equivalent in JS, provided for two-level quote nesting only, but stylistically
useful to make keywords and identifiers stand out from mundane strings.  Just a
thought.

/be

Comment 6

18 years ago
The fix I checked in fixed those nits.

Comment 7

18 years ago
verified in build 2000020904
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.