MIPS nanojit can overwrite verbose buffer (verbose output mode only)

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: Steven Johnson, Assigned: Rick Reitmaier)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin)

Attachments

(1 attachment)

1.75 KB, patch
Steven Johnson
: review?
Chris Dearman
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
Created attachment 534838 [details] [diff] [review]
Patch

The TRAMP macro (NativeMIPS.h) temporarily saves & swaps _nIns, but not _nInsAfter; asm_output depends on both of these being "close" to each other (8k).
Attachment #534838 - Flags: review?(chris)

Comment 1

7 years ago
Comment on attachment 534838 [details] [diff] [review]
Patch

Review of attachment 534838 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, looks good to me

Comment 2

6 years ago
Can this be committed?

Updated

6 years ago
Assignee: nobody → rreitmai
(Assignee)

Comment 3

6 years ago
stejohns http://hg.mozilla.org/projects/nanojit-central/rev/c7e1049ab9bd
Whiteboard: fixed-in-nanojit

Comment 4

6 years ago
changeset: 6736:f964d393121a
user:      Steven Johnson <stejohns>
summary:   Bug 659384 - MIPS nanojit can overwrite verbose buffer (verbose output mode only) (r=stejohns)

http://hg.mozilla.org/tamarin-redux/rev/f964d393121a

Updated

6 years ago
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin

Comment 5

4 years ago
Comment on attachment 534838 [details] [diff] [review]
Patch

Review of attachment 534838 [details] [diff] [review]:
-----------------------------------------------------------------

bugzilla thinks I still need to review this. It still looks good to me,
Has apparently landed a while ago + Nanojit is long gone.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.