659468 - Test Pilot compatibility currently needs to be manually bumped whenever we merge to aurora

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect)

Description

[Dave Townsend [:mossop]]

Attachment: bump maxVersion and version [checked in]

The merge to aurora went orange today because Test Pilot was still reporting a maxVersion of 5.0. We should consider preprocessing the maxVersion or something. For the moment though here is the easy fix to make aurora green.

Comment 1

[Dave Townsend [:mossop]]

Comment on attachment 534911 [details] [diff] [review]
bump maxVersion and version [checked in]

Landed:
http://hg.mozilla.org/mozilla-central/rev/cea568a2621b
http://hg.mozilla.org/releases/mozilla-aurora/rev/6058adc3a657

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: non-working patch

We have the same problem with the mobile feedback extension, mobile/app/profile/extensions/[e-mail]/install.rdf

I started this patch to make this extension's install process work more like the default theme.  It doesn't quite work because it ends up installing the extension's files flat, without preserving subdirectories.  Someone who knows the build system better could probably do this in a better way.

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This works for the desktop stuff. Matt, can you use this as a base for the mobile stuff, seems a little more straightforward than your approach.

Comment 5

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/a7684eca2bb7

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 544040 [details] [diff] [review]
patch rev 1

This is all ifdeffed off on nightly so we just need to land this on aurora to actually fix the problem there.

Comment 7

[Dave Townsend [:mossop]]

Landed on mozilla-aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/4310a4cfb3ae

Comment 8

[Dave Townsend [:mossop]]

Attachment: Unify packaging ifdefs

I wasn't going to do this here but I accidentally landed this on m-c at the same time as the reviewed patch, this just moves the ifdefs out to the shared Makefile to save updating in too many places. If this isn't right I'll just back it out of m-c

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 544088 [details] [diff] [review]
Unify packaging ifdefs

rs=me

Comment 10

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> This works for the desktop stuff. Matt, can you use this as a base for the
> mobile stuff, seems a little more straightforward than your approach.

Thanks, this should be helpful. I can work on it in a couple weeks, or someone else from mobile could do it now. (Mark, do w need any bumps to hard coded versions on nightly or aurora in the meantime?

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #10)

> someone else from mobile could do it now. (Mark, do w need any bumps to hard
> coded versions on nightly or aurora in the meantime?

Not for Nightly, we don't build feedback there. But we do for Aurora.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for mobile

Simple manual bump for mobile feedback addon. We should move to something like Mossop's patch for nightly soon.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 544566 [details] [diff] [review]
patch for mobile

Matt's on vacation, but Dave can review this too

Comment 14

[Dave Townsend [:mossop]]

Comment on attachment 544566 [details] [diff] [review]
patch for mobile

Review of attachment 544566 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 544566 [details] [diff] [review]
patch for mobile

This patch is all mobile and exclusively for aurora

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 544566 [details] [diff] [review]
patch for mobile

approved in the triage meeting

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 544566 [details] [diff] [review]
patch for mobile

http://hg.mozilla.org/releases/mozilla-aurora/rev/9ef85eef3e17

Comment 18

[Tomer Cohen :tomer]

This is happening again with Aurora Firefox 9.0. Do we have a bug for it?