659528 - unable to re-nominate for tracking

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Karl Tomlinson (:karlt)]

+++ This bug was initially created as a clone of Bug #659055 +++

Bug 655003 has been marked tracking-firefox6-.
I can set tracking-firefox6? in UI but submitting gives me:

"You tried to change the tracking-firefox6 field from - to ? , but only a user with the required permissions may change that field."

It should be possible re-nom when more information comes to light.

Comment 1

[:glob ✱]

this is a result of a decision on bug 656716, following another drive-by random flag setting incident.  clearly further refinement to the rules are required.

i propose allowing re-nomination of flags to users with editbugs access.

Comment 2

[Asa Dotzler [:asa]]

This is a very important part of our workflow. A user with edit bugs should absolutely be able to re-nominate in a bug flag. Who can help us with a quick fix here?

Comment 3

[:glob ✱]

(In reply to comment #2)
> Who can help us with a quick fix here?

i'm working on this now.

Comment 4

[:glob ✱]

Attachment: patch v1

just so things are crystal clear, here's a permissions matrix this patch implements:

  Old      New      No-Priv  editbugs  Driver
  Clear    Request  Yes      Yes       Yes
  Clear    Set      No       No        Yes
  Request  Clear    Yes      Yes       Yes
  Request  Set      No       No        Yes
  Set      Clear    No       Yes       Yes
  Set      Request  No       Yes       Yes

where "clear" is ---, "request" is ?, and "set" is anything else (+, -, ..)

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 535002 [details] [diff] [review]
patch v1

Looks good to me. One nit: the else clause needs reformatting to common style (single curly braces ending lines aren't right).

Gerv

Comment 6

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/BMO/Extension.pm
Committed revision 7722.

not yet live on production, i'll organise that once the right people are awake.

Comment 7

[:glob ✱]

(In reply to comment #6)
> not yet live on production, i'll organise that once the right people are
> awake.

this change should be live now.