659553 - JavaScript Error From FireFox xbl-marquee.xml

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect, P5)

Description

[Trent]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

When setting the contents of a cell innerHTML to a <Marquee> with JavaScript I get a JavaScript error from the xbl-marquee.xml page.

This is one of the many weird JavaScript issues that is happeneing since upgrading to 4.0.

Reproducible: Always

Steps to Reproduce:
Create a mouse over the sets the inner contects of an element to something in a Marquee, then change it frequently.

Actual Results:  
Got the error in my console.

Expected Results:  
Not thrown an Error.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Can you please attach a testcase showing the problem or provide a URL to one?

Comment 2

[Trent]

<!DOCTYPE html>
<html>
    <head></head>
    <body>
        
        <button onmouseover="document.getElementById('TheDiv').innerHTML = 'Hey There';">Button 1</button>
        <button onmouseover="document.getElementById('TheDiv').innerHTML = '<marquee>Hey There</marquee>';">Button 2</button>
        <div id="TheDiv" style="border:red solid 1px; width:100px;"></div>
    </body>
</html>

This is the HTML, you can stop the error by using document.getElementsByTagName('marquee')[0].stop();

Comment 3

[Henri Sivonen (:hsivonen)]

Confirming. This doesn't look like a parser problem, though. Not sure where this belongs. Guessing DOM.

Comment 4

[Boris Zbarsky [:bzbarsky]]

So is the error you're seeing this one:

Error: myThis._doMove is not a function
Source File: chrome://xbl-marquee/content/xbl-marquee.xml
Line: 509

?

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to comment #4)
> So is the error you're seeing this one:
> 
> Error: myThis._doMove is not a function
> Source File: chrome://xbl-marquee/content/xbl-marquee.xml
> Line: 509
> 
> ?

That's the error I saw.

Comment 6

[Boris Zbarsky [:bzbarsky]]

So the problem is that we actually unhook the XBL proto chain now when removing from the document, but the timer remains live.  And we do NOT call the XBL dtor in that situation, so that can't be used to cancel the timer.

Martijn, can we just change xbl-marquee to handle _doMove not being there?

Comment 7

[Martijn Wargers (dead)]

I guess you could do that.
Or perhaps the timers should be removed when _doMove does not exist?

I guess some testing with IE has to be done to see how they handle this kind of dynamice adding and removing of marguees.

Comment 8

[Boris Zbarsky [:bzbarsky]]

> Or perhaps the timers should be removed when _doMove does not exist?

That's what I meant: when no _doMove, just clearInterval and bail out.

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 10

[Karl Dubost💡 :karlcow]

Per Bug 1425874 Marquee is not dependent anymore of XBL.
And this is now INVALID.