Closed Bug 659610 Opened 9 years ago Closed 2 years ago
Remove or inline Set
Attr Helper and Get Attr Helper (from ns Generic HTMLElement)
59 bytes, text/x-review-board-request
GetAttrHelper is used only once and is very basic: it calls GetAttr() and returns NS_OK. SetAttrHelper is used multiple times (inside nsGenericHTMLElement only) and only call SetAttr() with kNameSpace_None and aNotify=PR_TRUE. They have been introduced with bug 244921 for code size optimization. Do we really care?
Once we have all of the nsIDOMHTML*Element interfaces cleaned up, these functions should no longer be needed. They're basically just Get/SetHTMLAttr with an nsresult return, which we will no longer need.
Assignee: nobody → kyle
Assignee: kyle → adrian.wielgosik
Status: NEW → ASSIGNED
Comment on attachment 8953865 [details] Bug 659610 - Remove nsGenericHTMLElement::SetAttrHelper and related helper macros. https://reviewboard.mozilla.org/r/223020/#review229394
Attachment #8953865 - Flags: review?(kyle) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/f674159f8c52 Remove nsGenericHTMLElement::SetAttrHelper and related helper macros. r=qdot
You need to log in before you can comment on or make changes to this bug.