Closed Bug 659610 Opened 9 years ago Closed 2 years ago

Remove or inline SetAttrHelper and GetAttrHelper (from nsGenericHTMLElement)

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mounir, Assigned: adrian17)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

GetAttrHelper is used only once and is very basic: it calls GetAttr() and returns NS_OK.
SetAttrHelper is used multiple times (inside nsGenericHTMLElement only) and only call SetAttr() with kNameSpace_None and aNotify=PR_TRUE.

They have been introduced with bug 244921 for code size optimization. Do we really care?
Once we have all of the nsIDOMHTML*Element interfaces cleaned up, these functions should no longer be needed. They're basically just Get/SetHTMLAttr with an nsresult return, which we will no longer need.
Assignee: nobody → kyle
Blocks: 1387169
Assignee: kyle → adrian.wielgosik
Status: NEW → ASSIGNED
Comment on attachment 8953865 [details]
Bug 659610 - Remove nsGenericHTMLElement::SetAttrHelper and related helper macros.

https://reviewboard.mozilla.org/r/223020/#review229394
Attachment #8953865 - Flags: review?(kyle) → review+
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/f674159f8c52
Remove nsGenericHTMLElement::SetAttrHelper and related helper macros. r=qdot
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f674159f8c52
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.