Closed
Bug 659675
Opened 13 years ago
Closed 13 years ago
--with-system-png fails with libpng-1.4+
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
People
(Reporter: mi+mozilla, Assigned: mi+mozilla)
Details
Attachments
(1 file)
|
471 bytes,
patch
|
Details | Diff | Splinter Review |
png_voidp_NULL is not defined in modern libpng and various people recommend using NULL or 0: https://bbs.archlinux.org/viewtopic.php?id=90268 https://bugs.webkit.org/show_bug.cgi?id=33287 In my opinion, NULL is the correct value...
|
||
Comment 1•13 years ago
|
||
Since this is in ImageLib, moving to a more appropriate product/component.
Component: Build Config → ImageLib
Product: Thunderbird → Core
QA Contact: build-config → imagelib
Version: 3.1 → Trunk
|
||
Comment 2•13 years ago
|
||
Comment on attachment 535111 [details] [diff] [review] Use NULL instead of the no longer defined "png_voidp_NULL" This change was made some time ago in mozilla-central. The png_voidp_NULL constant was changed to nsnull.
|
||
Updated•13 years ago
|
Attachment #535111 -
Flags: review?(joe)
|
||
Updated•13 years ago
|
Attachment #535111 -
Attachment is patch: true
|
||
Comment 3•13 years ago
|
||
Comment on attachment 535111 [details] [diff] [review] Use NULL instead of the no longer defined "png_voidp_NULL" Glenn's right - this patch is implicitly already applied, as we fixed this problem in another bug (which I can't find right now). Mikhail, thanks for the patch!
Attachment #535111 -
Flags: review?(joe)
|
|
||
Updated•13 years ago
|
Assignee: nobody → mi+mozilla
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•