--with-system-png fails with libpng-1.4+

RESOLVED FIXED

Status

()

Core
ImageLib
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Mikhail T., Assigned: Mikhail T.)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 535111 [details] [diff] [review]
Use NULL instead of the no longer defined "png_voidp_NULL"

png_voidp_NULL is not defined in modern libpng and various people recommend using NULL or 0:

https://bbs.archlinux.org/viewtopic.php?id=90268
https://bugs.webkit.org/show_bug.cgi?id=33287

In my opinion, NULL is the correct value...
Since this is in ImageLib, moving to a more appropriate product/component.
Component: Build Config → ImageLib
Product: Thunderbird → Core
QA Contact: build-config → imagelib
Version: 3.1 → Trunk
Comment on attachment 535111 [details] [diff] [review]
Use NULL instead of the no longer defined "png_voidp_NULL"

This change was made some time ago in mozilla-central.  The png_voidp_NULL constant was changed to nsnull.

Updated

6 years ago
Attachment #535111 - Flags: review?(joe)

Updated

6 years ago
Attachment #535111 - Attachment is patch: true
Comment on attachment 535111 [details] [diff] [review]
Use NULL instead of the no longer defined "png_voidp_NULL"

Glenn's right - this patch is implicitly already applied, as we fixed this problem in another bug (which I can't find right now).

Mikhail, thanks for the patch!
Attachment #535111 - Flags: review?(joe)
Assignee: nobody → mi+mozilla
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.