659684 - Add way to cancel all jobs associated with a changeset

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Sometimes you want to cancel everything and not just individual builds. Currently, doing so is a bit of a pain.

Comment 1

[Cameron McCormack (:heycam)]

It would be nice if the self-serve API exposed a way of cancelling all builds for a push at once, but we can still queue up all the individual cancellation requests without that.  I think the biggest problem is figuring out where in the UI we want to put the cancel button. :)

Comment 2

[(no longer active)]

(In reply to comment #1)
> It would be nice if the self-serve API exposed a way of cancelling all builds
> for a push at once, but we can still queue up all the individual cancellation
> requests without that.  I think the biggest problem is figuring out where in
> the UI we want to put the cancel button. :)

Right next to the "compare" checkbox?

I guess we do want confirmation for that though, since it's possible to hit it by mistake.

Comment 3

[Chris AtLee [:catlee]]

(In reply to comment #1)
> It would be nice if the self-serve API exposed a way of cancelling all
> builds for a push at once, but we can still queue up all the individual
> cancellation requests without that.  I think the biggest problem is figuring
> out where in the UI we want to put the cancel button. :)

I think I can do that relatively easily.

Comment 4

[(no longer active)]

Cameron, now that bug 636027 has been fixed, can you pick this up, please?  :-)

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This needs to not cancel actual builds, unless you're on try.

Comment 6

[Cameron McCormack (:heycam)]

Does catlee's change to the Build API do that automatically?  If not, maybe it could have a parameter added to it?  (Otherwise, we're back to making a cancellation request for each running builder, which I was hoping to avoid.)  In the meantime, maybe we should only expose UI for this when looking at try?

Comment 7

[(no longer active)]

(In reply to comment #6)
> In the meantime, maybe we should only expose UI for this when looking at try?

That would make sense to me.

Comment 8

[Cameron McCormack (:heycam)]

Attachment: Add a button (only on try) to cancel all jobs for a push.

This is deployed on http://tbpl.mcc.id.au/ at the moment, if you want to see how it looks.

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 546641 [details] [diff] [review]
Add a button (only on try) to cancel all jobs for a push.

Looks good!

Do the two occurrences of display:inline in the stylesheet have any effect? I'd think not because position:absolute should turn them into display:block anyway.
r+ with those removed or justified

Comment 10

[Cameron McCormack (:heycam)]

You're right, I will remove them.

Should I land this on the default or production branch?  I'm not really sure what the situation is there.  The diff applies cleanly to both.

Comment 11

[Markus Stange [:mstange]]

Depends on how soon you want it to be deployed. Deploying the default branch is tracked in bug 669000, and I don't know how long that will take. You might have a chance at getting it deployed sooner when you land on the production branch, but maybe that's not worth it... not sure.

Comment 12

[Cameron McCormack (:heycam)]

OK, I pushed it to the production branch:

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/052258e7b517

Please deploy at will.

Comment 13

[(no longer active)]

(In reply to comment #12)
> OK, I pushed it to the production branch:
> 
> http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/052258e7b517
> 
> Please deploy at will.

Done.  Thanks!

Comment 14

[Cameron McCormack (:heycam)]

Thank you!  I filed bug 673246 for letting the self-serve API cancel jobs except for builds, and bug 673247 to enable the "cancel all" button for non-try trees.