659706 - Use better names for DOM mutating methods on nsINode

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Currently it's kind of hard to tell the difference between the "internal" methods like RemoveChildAt/InsertChildAt and "DOM" methods like InsertBefore/ReplaceChild/AppendChild.

The difference is quite important in that for example the former doesn't fire DOMNodeRemoved mutation events or do any safety checks to prevent illegal DOM graphs.

We should come up with names that makes it more clear what the difference is. Suggestions welcome.

Comment 1

[Boris Zbarsky [:bzbarsky]]

InternalRemoveChild/InternalInsertChildAt ?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Works for me.

Smaug, sounds good to you (given that this was your request originally)?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Internal prefix or postfix is something I was thinking too.

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.