Closed Bug 659730 Opened 13 years ago Closed 13 years ago

Option window-->Network & Disk Space has disk space textbox for cache too little

Categories

(Thunderbird :: Message Reader UI, defect)

x86
Windows 7
defect
Not set
minor

Tracking

(thunderbird6 fixed)

RESOLVED FIXED
Thunderbird 7.0
Tracking Status
thunderbird6 --- fixed

People

(Reporter: Aureliano, Assigned: Paenglab)

Details

(Keywords: polish)

Attachments

(2 files)

Attached image bug-in-action
The textbox where user insert "disk space" for cache is too little as show in attached screenshot

Mozilla/5.0 (Windows NT 6.1; rv:7.0a1) Gecko/20110525 Thunderbird/3.4a1pre
On my system it has enough place.

But with changing the size from 2 to 3 on the line <http://mxr.mozilla.org/comm-central/source/mail/components/preferences/advanced.xul#313> would give more space for the box. Should it be done like this? I can provide a patch.
That seems reasonable to me.  Perhaps we should even take it up to 4?
For reference, the offlineCompactFolderMin box the row below has size="5", thus it may be good to make them of equal width (actual size depends on font).

Also, cacheSize doesn't have any min/max/increment defined, thus you can dial it up to several millions if you want to; min="0" (no cache) and max="8192" may be reasonable values, maybe with an increment="10" similar to compacting.
> (comment #3) the offlineCompactFolderMin box the row below has size="5",

The reason for this likely being that TB 3.1.x has 2097151 (2048*1024-1) KB as maximum value (now MB), which barely fits with Windows Classic desktop theme. It would be interesting to know how that "size" value actually maps to width...
Attached patch PatchSplinter Review
I took the same as in Firefox (size="4" max="1024"). min="0" isn't needed because it doesn't go negative.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #535402 - Flags: review?(bwinton)
Parity with Firefox should be ok, I suggested 8GB to fill up the four digits to some round number. However, even 1GB for cache sounds quite high to me, but some users may want it, thus no reason to prevent them from doing it.  :-)
Comment on attachment 535402 [details] [diff] [review]
Patch

Review of attachment 535402 [details] [diff] [review]:
-----------------------------------------------------------------

UI-wise I like it.  ui-r=me.
Code-wise, I can't see anything to complain about either.  r=me.

Thanks,
Blake.
Attachment #535402 - Flags: ui-review+
Attachment #535402 - Flags: review?(bwinton)
Attachment #535402 - Flags: review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/1cd9c6cf8b23
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
Attachment #535402 - Flags: approval-comm-aurora?
Attachment #535402 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: