If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Quicksearch only works for ASCII strings (when quoted)

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Query/Bug List
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: glob)

Tracking

unspecified
Bugzilla 4.0
Bug Flags:
approval +
approval4.0 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

680 bytes, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
ALL su:⌘
https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL%20su%3A%E2%8C%98

9 bugs

ALL su:"⌘"
https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL%20su%3A%22%E2%8C%98%22

0 bugs :(
(Assignee)

Comment 1

6 years ago
Created attachment 535302 [details] [diff] [review]
patch v1

url_quote calls utf8::encode(), so we need to utf8::decode after calling url_decode.
Assignee: query-and-buglist → glob
Status: NEW → ASSIGNED
Attachment #535302 - Flags: review?(mkanat)

Updated

6 years ago
Severity: major → minor
Target Milestone: --- → Bugzilla 4.0

Comment 2

6 years ago
Comment on attachment 535302 [details] [diff] [review]
patch v1

Interestingly enough, this is the only code using url_decode. Let's modify url_decode instead of hacking a fix into Quicksearch.pm.
Attachment #535302 - Flags: review?(mkanat) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 535571 [details] [diff] [review]
patch v2
Attachment #535302 - Attachment is obsolete: true
Attachment #535571 - Flags: review?(mkanat)

Comment 4

6 years ago
Comment on attachment 535571 [details] [diff] [review]
patch v2

If you've tested this, it looks okay to me. My concern is what happens if url_decode gets a string that's already tagged as utf8?
Attachment #535571 - Flags: review?(mkanat) → review+

Updated

6 years ago
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 5

6 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Util.pm
Committed revision 7828.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Util.pm
Committed revision 7601.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED

Updated

6 years ago
Flags: approval4.2+
You need to log in before you can comment on or make changes to this bug.