Replace nsContentUtils::GetLocalizedStringPref() with Preferences::GetLocalizedCString() or Preferences::GetLocalizedString()

RESOLVED FIXED in mozilla7

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Created attachment 535232 [details] [diff] [review]
Part.1 Add GetLocalizedString() for nsACString
Attachment #535232 - Flags: review?(roc)
Created attachment 535233 [details] [diff] [review]
Part.2 Replace
Attachment #535233 - Flags: review?(roc)
Comment on attachment 535232 [details] [diff] [review]
Part.1 Add GetLocalizedString() for nsACString

Review of attachment 535232 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #535232 - Flags: review?(roc) → review+
Comment on attachment 535233 [details] [diff] [review]
Part.2 Replace

Review of attachment 535233 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #535233 - Flags: review?(roc) → review+
Actually, see bug 659820 ... it would be ideal if we can make this API return a string directly, if we can make that efficient.
Created attachment 535311 [details] [diff] [review]
Part.2 Replace with direct return methods
Attachment #535233 - Attachment is obsolete: true
Attachment #535311 - Flags: review?(roc)
We need a new version of part 1, don't we?
Blocks: 660121
(In reply to comment #6)
> We need a new version of part 1, don't we?

Actually, no. The order of patches in my queue is:

bug 659820 part.1
bug 659821 part.1
bug 659820 part.2

The bug 659820 part.2 renames GetLocalizedString() to GetLocalizedCString().
I think you don't like the messy order, I'll merge bug 659821 part.1 and bug 659820 part.2.
Comment on attachment 535232 [details] [diff] [review]
Part.1 Add GetLocalizedString() for nsACString

(In reply to comment #8)
> I think you don't like the messy order, I'll merge bug 659821 part.1 and bug
> 659820 part.2.

Simply, the part.1 of this bug is moved to bug 659820 as part.2.
Attachment #535232 - Attachment is obsolete: true
Created attachment 535549 [details] [diff] [review]
Repace them
Attachment #535311 - Attachment is obsolete: true
Attachment #535311 - Flags: review?(roc)
Attachment #535549 - Flags: review?(roc)
Comment on attachment 535549 [details] [diff] [review]
Repace them

Review of attachment 535549 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #535549 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/ff89f3047bd5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Summary: Replace nsContentUtils::GetLocalizedStringPref() with Preferences::GetLocalizedString() → Replace nsContentUtils::GetLocalizedStringPref() with Preferences::GetLocalizedCString() or Preferences::GetLocalizedString()
Depends on: 660401
You need to log in before you can comment on or make changes to this bug.