Closed Bug 659956 Opened 11 years ago Closed 11 years ago

Remove unused variable from nsOfflineCacheUpdate.cpp

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove unused variable from nsOfflineCacheUpdate.cpp
1.07 KB, patch
emorley
: review+
Details | Diff | Splinter Review 
Similar to bug 619590, but for nsOfflineCacheUpdate.cpp

> 511     nsCOMPtr<nsICachingChannel> oldCachingChannel =
> 512         do_QueryInterface(aOldChannel);

|oldCachingChannel| is not used anywhere else (http://mxr.mozilla.org/mozilla-central/search?string=oldCachingChannel) so can be removed.
Two line removal.

Thanks :-)
Attachment #535356 - Flags: review?(bzbarsky)
Comment on attachment 535356 [details] [diff] [review]
Remove unused variable from nsOfflineCacheUpdate.cpp

r=me
Attachment #535356 - Flags: review?(bzbarsky) → review+
Only change is adding the patch author/username, after Tortoisehg apparently ate my hgrc.

Carrying forwards r+.
Attachment #535356 - Attachment is obsolete: true
Attachment #535393 - Flags: review+
Keywords: checkin-needed
Pushed:
http://hg.mozilla.org/mozilla-central/rev/2280f0d23ce2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.