Last Comment Bug 659956 - Remove unused variable from nsOfflineCacheUpdate.cpp
: Remove unused variable from nsOfflineCacheUpdate.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Ed Morley [:emorley]
:
:
Mentors:
Depends on: 619590
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-26 08:55 PDT by Ed Morley [:emorley]
Modified: 2011-05-27 01:06 PDT (History)
2 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
Remove unused variable from nsOfflineCacheUpdate.cpp (1.04 KB, patch)
2011-05-26 09:03 PDT, Ed Morley [:emorley] 		bzbarsky: review+
Details | Diff | Splinter Review
Remove unused variable from nsOfflineCacheUpdate.cpp (1.07 KB, patch)
2011-05-26 10:30 PDT, Ed Morley [:emorley] 		emorley: review+
Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Ed Morley [:emorley] 2011-05-26 08:55:25 PDT 
Similar to bug 619590, but for nsOfflineCacheUpdate.cpp

> 511     nsCOMPtr<nsICachingChannel> oldCachingChannel =
> 512         do_QueryInterface(aOldChannel);

|oldCachingChannel| is not used anywhere else (http://mxr.mozilla.org/mozilla-central/search?string=oldCachingChannel) so can be removed.
Comment 1 Ed Morley [:emorley] 2011-05-26 09:03:24 PDT 
Created attachment 535356 [details] [diff] [review]
Remove unused variable from nsOfflineCacheUpdate.cpp

Two line removal.

Thanks :-)
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-05-26 10:13:53 PDT 
Comment on attachment 535356 [details] [diff] [review]
Remove unused variable from nsOfflineCacheUpdate.cpp

r=me
Comment 3 Ed Morley [:emorley] 2011-05-26 10:30:44 PDT 
Created attachment 535393 [details] [diff] [review]
Remove unused variable from nsOfflineCacheUpdate.cpp

Only change is adding the patch author/username, after Tortoisehg apparently ate my hgrc.

Carrying forwards r+.
Comment 4 Daniel Holbert [:dholbert] 2011-05-26 11:17:06 PDT 
http://hg.mozilla.org/projects/cedar/rev/2280f0d23ce2
Comment 5 Mounir Lamouri (:mounir) 2011-05-27 01:06:37 PDT 
Pushed:
http://hg.mozilla.org/mozilla-central/rev/2280f0d23ce2
Note You need to log in before you can comment on or make changes to this bug.