660079 - Add helper method to reset permissions in Utils.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

This is a dependency for the Safe Browsing tests. Basically, domains are whitelisted when the Ignore Warning button is selected (as designed for Firefox 6 onward). This breaks the tests which assume the domain to always be blacklisted.  

The interim solution, until an API rewrite is done, is to create a helper method which will reset the permissions and keep the test domain blacklisted.

Comment 1

[u279076]

Attachment: Patch v1.0

Patch to add nsIPermissionManager::remove(host,type) helper function to the Utils API.

Comment 2

[u279076]

(In reply to comment #1)
> Created attachment 535496 [details] [diff] [review] [review]
> Patch v1.0
> 
> Patch to add nsIPermissionManager::remove(host,type) helper function to the
> Utils API.

NOTE: I've tested this with SafeBrowsingWarningPages and it fixes the failure.

Comment 3

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 535496 [details] [diff] [review]
Patch v1.0

Looks fine, r+. Since I'm not sure what branch(es) this applies to, please go ahead and land.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 535496 [details] [diff] [review]
Patch v1.0

>+ * @param {AUTF8String} aHost
>+ *        The host whose permission will be removed
>+ * @param {string} aType
>+ *        The type of permission to be removed

Simply use 'String' in both cases. From the JS side we do not differentiate between different string types.

Comment 5

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13898737

Comment 6

[u279076]

Attachment: Patch v1.1 [checked-in]

Patch with Henrik's nit addressed. This patch will be checked in shortly. Again, this only affects Firefox 6.0+ branches.

Comment 7

[u279076]

Comment on attachment 535654 [details] [diff] [review]
Patch v1.1 [checked-in]

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/eb8aa5555a68