660104 - can't push to hg

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[[e-mail] (:bhearsum)]

I got the following Traceback when trying to push to hg:
pushing to ssh://hg.mozilla.org/users/bhearsum_mozilla.com/tools
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 2 changes to 2 files
remote: error: pretxnchangegroup.z_broker hook raised an exception: super() argument 1 must be type, not classobj
remote: transaction abort!
remote: rollback completed
remote: ** unknown exception encountered, details follow
remote: ** report bug details to http://mercurial.selenic.com/bts/
remote: ** or [e-mail]
remote: ** Python 2.4.3 (#1, Jun 11 2009, 14:09:58) [GCC 4.1.2 20080704 (Red Hat 4.1.2-44)]
remote: ** Mercurial Distributed SCM (version 1.5.4)
remote: ** Extensions loaded: hgwebjson, pushlog-feed, buglink
remote: Traceback (most recent call last):
remote:   File "/usr/bin/hg", line 27, in ?
remote:     mercurial.dispatch.run()
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 16, in run
remote:     sys.exit(dispatch(sys.argv[1:]))
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 30, in dispatch
remote:     return _runcatch(u, args)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 50, in _runcatch
remote:     return _dispatch(ui, args)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 471, in _dispatch
remote:     return runcommand(lui, repo, cmd, fullargs, ui, options, d)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 341, in runcommand
remote:     ret = _runcommand(ui, options, cmd, d)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 522, in _runcommand
remote:     return checkargs()
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 476, in checkargs
remote:     return cmdfunc()
remote:   File "/usr/lib/python2.4/site-packages/mercurial/dispatch.py", line 470, in <lambda>
remote:     d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/util.py", line 401, in check
remote:     return func(*args, **kwargs)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/commands.py", line 2904, in serve
remote:     s.serve_forever()
remote:   File "/usr/lib/python2.4/site-packages/mercurial/sshserver.py", line 45, in serve_forever
remote:     while self.serve_one():
remote:   File "/usr/lib/python2.4/site-packages/mercurial/sshserver.py", line 57, in serve_one
remote:     impl()
remote:   File "/usr/lib/python2.4/site-packages/mercurial/sshserver.py", line 208, in do_unbundle
remote:     r = self.repo.addchangegroup(fp, 'serve', self.client_url())
remote:   File "/usr/lib/python2.4/site-packages/mercurial/localrepo.py", line 2120, in addchangegroup
remote:     url=url, pending=p)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/localrepo.py", line 152, in hook
remote:     return hook.hook(self.ui, self, name, throw, **args)
remote:   File "/usr/lib/python2.4/site-packages/mercurial/hook.py", line 142, in hook
remote:     r = _pythonhook(ui, repo, name, hname, hookfn, args, throw) or r
remote:   File "/usr/lib/python2.4/site-packages/mercurial/hook.py", line 68, in _pythonhook
remote:     r = obj(ui=ui, repo=repo, hooktype=name, **args)
remote:   File "/usr/lib/python2.4/site-packages/mozhghooks/broker.py", line 352, in send_messages
remote:     get_configuration(ui)
remote:   File "/usr/lib/python2.4/site-packages/mozhghooks/broker.py", line 131, in get_configuration
remote:     raise MissingRequiredConfigValue(req)
remote:   File "/usr/lib/python2.4/site-packages/mozhghooks/broker.py", line 51, in __init__
remote:     super(MissingRequiredConfigValue, self).__init__()
remote: TypeError: super() argument 1 must be type, not classobj
abort: unexpected response: empty string


Noahm disabled a hook, which made pushing work again.

Comment 1

[Noah Meyerhans [:noahm]]

This was caused by LegNeato's new hook for pushing to pulse.mozilla.org. The hook is disabled while he investigates.

Comment 2

[LegNeato]

This was because I had noah update the script from github and I forgot to tell him to change the config (bug 603029 wanted REPO_ROOT to change to BASE_PATH)

Comment 3

[Noah Meyerhans [:noahm]]

Re-enabling the hook with christian's change:

Index: hgrc-rw
===================================================================
--- hgrc-rw	(revision 15326)
+++ hgrc-rw	(working copy)
@@ -27,7 +27,7 @@
 sorthooks = True
 pretxnchangegroup.z_loghistory = python:mozhghooks.pushlog.log
 changegroup.z_purgeurl = /repo/hg/scripts/purgeurl
-# pretxnchangegroup.z_broker = python:mozhghooks.broker.send_messages
+pretxnchangegroup.z_broker = python:mozhghooks.broker.send_messages
 
 [extensions]
 hgwebjson = /repo/hg/extensions/hgwebjson.py
@@ -45,5 +45,5 @@
 BROKER_USER = hg_shim
 BROKER_PASS = W3_l1ke_f1x3s
 MSG_EXCHANGE = org.mozilla.exchange.code
-REPO_ROOT = /repo/hg/mozilla
+BASE_PATH = /repo/hg/mozilla

Comment 4

[[e-mail] (:bhearsum)]

And I can still push! FIXED, i think!