Closed Bug 660219 Opened 10 years ago Closed 10 years ago

patcher needs to support objdir building

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(2 files, 1 obsolete file)

Picking up a very recent revision of mozilla-beta in bug 658094 had the unfortunate side effect of also picking up the bug that forces us to build in an objdir. Patcher needs to learn how to cope with objdirs.
Build patcher tools in an objdir, and change MAR/MBSDIFF variables to point at it.

Worked fine in my manual test.
Attachment #535617 - Flags: review?(armenzg)
Comment on attachment 535617 [details] [diff] [review]
build in an objdir in patcher

*stamp*
Attachment #535617 - Flags: review?(armenzg) → review+
Comment on attachment 535617 [details] [diff] [review]
build in an objdir in patcher

Landed, and moved the UPDATE_PACKAGING_R14 tag:
cvs commit: Examining .
Checking in MozAUSLib.pm;
/cvsroot/mozilla/tools/patcher/MozAUSLib.pm,v  <--  MozAUSLib.pm
new revision: 1.19; previous revision: 1.18
done
Checking in patcher2.pl;
/cvsroot/mozilla/tools/patcher/patcher2.pl,v  <--  patcher2.pl
new revision: 1.42; previous revision: 1.41
done
$ cvs tag UPDATE_PACKAGING_R14 MozAUSLib.pm patcher2.pl 
W MozAUSLib.pm : UPDATE_PACKAGING_R14 already exists on version 1.18 : NOT MOVING tag to version 1.19
W patcher2.pl : UPDATE_PACKAGING_R14 already exists on version 1.41 : NOT MOVING tag to version 1.42
$ cvs tag -F UPDATE_PACKAGING_R14 MozAUSLib.pm patcher2.pl 
T MozAUSLib.pm
T patcher2.pl
Attachment #535617 - Flags: checked-in+
Re-validated this in staging.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Of course, once my test got to --create-patches I found an issue.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #535642 - Flags: review?(armenzg)
Comment on attachment 535642 [details] [diff] [review]
use OBJDIR when adding dist/host/bin to $PATH

nice :)
Attachment #535642 - Flags: review?(armenzg) → review+
Attached patch the right patchSplinter Review
Attachment #535642 - Attachment is obsolete: true
Attachment #535645 - Flags: review?(coop)
Attachment #535645 - Flags: review?(coop) → review+
Comment on attachment 535645 [details] [diff] [review]
the right patch

cvs commit: Examining .
? b
Checking in patcher2.pl;
/cvsroot/mozilla/tools/patcher/patcher2.pl,v  <--  patcher2.pl
new revision: 1.43; previous revision: 1.42
done
[] bhearsum@voot:~/Mozilla/checkouts/clean/patcher$ cvs tag UPDATE_PACKAGING_R14 patcher2.pl
W patcher2.pl : UPDATE_PACKAGING_R14 already exists on version 1.42 : NOT MOVING tag to version 1.43
[] bhearsum@voot:~/Mozilla/checkouts/clean/patcher$ cvs tag -F UPDATE_PACKAGING_R14 patcher2.pl
T patcher2.pl
Attachment #535645 - Flags: checked-in+
FWIW, this shouldn't have *forced* you to build in an object dir ... you should have been able to set MOZ_OBJDIR=path/to/srcdir.
Ah, I wasn't sure that was supported at all anymore. In any case, it doesn't *hurt* to build in an objdir here. Thanks for that tip though, khuey!
This worked fine in 5.0b3
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.