660223 - S in the history view heading should be localizable and have a long description

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Scoobidiver (away)]

S and its description should be localizable.
The description should also be more explicit:
Significance:<br>MT: Major content changes<br>M: Content changes<br><empty>: Minor changes".

Comment 1

[Tanay Gavankar [:tgavankar]]

There doesn't seem to be a way to put linebreaks within the title attribute of abbr tags, so it has to all be one line. At the moment, it's:

Significance: MT - Major Content Changes, M - Content Changes, Empty - Minor changes


Any better suggestions, or shall I commit this?

Comment 2

[Kadir Topal [:atopal]]

Please use:

MT: Major Content Changes. M: Content Changes. Empty: Minor changes

This way it's clearer which description belongs to which letter

Comment 3

[Scoobidiver (away)]

(In reply to comment #2)
> MT: Major Content Changes. M: Content Changes. Empty: Minor changes
Significance must remain to give a meaning to the S heading.

Comment 4

[Tanay Gavankar [:tgavankar]]

I agree with Scoobidiver in this case, the S needs to be defined with Significance.

If the chosen punctuation makes it confusing as to what goes with what, how about something like:


Significance - MT: Major Content Changes, M: Content Changes, Empty: Minor changes




(We could also replace the commas with semicolons or something.)

Comment 5

[Kadir Topal [:atopal]]

works for me, but please change the commas to full stops. Thanks!

Comment 6

[Tanay Gavankar [:tgavankar]]

Done in:

https://github.com/jsocol/kitsune/commit/08df24c

Comment 7

[Rebecca Billings [:rbillings]]

Verified changes display [with periods, not commas] in Verbatim.