Closed Bug 660242 Opened 13 years ago Closed 13 years ago

Need to quote location URLs on repackage service

Categories

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Builder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Builder 0.9.5

People

(Reporter: clouserw, Assigned: zalun)

Details

(Whiteboard: [post-freeze+]) 

I was using this URL in the repackager:

location=http://ftp.mozilla.org/pub/mozilla.org/addons/281358/status_watch-0.2.rev11-tb+fx+fn.xpi

and it was trying to retrieve "....-tb fx fn.xpi".  I think urllib interprets '+' as ' '.  Switching to % encoded pluses fixed it.  I think urllib.quote would solve this, but haven't tested it.  Have to make sure it doesn't break.

In addition, there was no failure in the logs when it failed to retrieve the URL with spaces - we should verify there is logging in case the package fails to be retrieved.
I use urllib.urlencode
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.