660473 - Replace PR_Atomic* functions with macros in mailnews

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Steve Snyder]

Attachment: Replace PR_Atomic* functions with macros

Replaces NSPR PR_AtomicIncrement() and  PR_AtomicDecrement() functions with equivalent macros.  Done for performance reasons and for compatibity with the rest of the contemporary Gecko codebase.

See also bug 592557 for non-mailnews replacements.

Comment 1

[[e-mail]]

Comment on attachment 535882 [details] [diff] [review]
Replace PR_Atomic* functions with macros

>-  nsrefcnt count = PR_AtomicDecrement((PRInt32 *)&mRefCnt);
>+  nsrefcnt count = PR_ATOMIC_DECREMENT((PRInt32 *)&mRefCnt);
This should be NS_AtomicDecrementRefcnt(mRefCnt)

r=me with that fixed.

Comment 2

[Ludovic Hirlimann [:Usul]]

Steve can you upload a patch fixing the review ?

Comment 3

[Steve Snyder]

Attachment: Replace PR_Atomic* functions - updated

Addressed review comment.

Comment 4

[Ludovic Hirlimann [:Usul]]

Comment on attachment 537337 [details] [diff] [review]
Replace PR_Atomic* functions - updated

Carrying r+ from Neil

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/0bf46f79173a