660497 - AC_SUBST(ANDROID) since people keep pretending that it is, and not looking at the fact that their Makefile ifndef isn't doing what they want

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: fix

Sigh, http://mxr.mozilla.org/mozilla-central/search?string=def+android&find=Makefile.in

Comment 1

[Phil Ringnalda (:philor)]

Attachment: fix, actually applied

hg qpop -a && hg qdiff turns out not to be as effective as it could be.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 535887 [details] [diff] [review]
fix, actually applied

Actually, this won't do what you want.  It's only substituting if we're on android, so on non-android ifdef ANDROID will be true since ANDROID = @ANDROID@.

Comment 3

[Phil Ringnalda (:philor)]

Attachment: fix?, v2

http://dev.philringnalda.com/tbpl/?tree=Try&rev=c64d30a7baf8, maybe, with a little luck.

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 535888 [details] [diff] [review]
fix?, v2

Sigh.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: probable fix, v3

Boy, this is going to be a bug to list front and center on the old resume, isn't it?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 535890 [details] [diff] [review]
probable fix, v3

I *think* this does it.

Comment 7

[Phil Ringnalda (:philor)]

Pushed http://hg.mozilla.org/mozilla-central/rev/8d752162e810 as a bustage fix, to make disabling the failing tests actually work, so I'll have to revert that once I can push this.

Comment 8

[(not currently active) Ted Mielczarek]

I really don't want this. I have railed against this in the past. We already have OS_TARGET = Android, that's what people should be using. If people are not testing their build changes, then that's a problem we cannot fix with patches.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Per comment 8.

Comment 10

[Benjamin Smedberg]

I think we should alternately add this to autoconf.mk.in:

ANDROID = $(error You are using the ANDROID variable in a makefile incorrectly. You should be using OS_TARGET)

Comment 11

[(not currently active) Ted Mielczarek]

Will that work if the only way people use it is "ifdef ANDROID"?

Comment 12

[Benjamin Smedberg]

Crap, it doesn't :-(