Closed Bug 660655 Opened 10 years ago Closed 10 years ago

Update class name of the Plugin check link in the Add-ons Manager

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla7

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

With the landing of bug 656269 we got a link to the plugin checker page from the plugin list view. Sadly it didn't got an id you could easily reference. For our Mozmill tests it would be handy to have such an id.
Blocks: 656269
Version: 5 Branch → Trunk
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: Add Id to Plugin check link in the Add-ons Manager → Update class name of the Plugin check link in the Add-ons Manager
Attached patch Patch v1 (obsolete) — Splinter Review
This patch updates the class name accordingly to the other buttons for about:addons. Further I have removed this unnecessary hard-coded en-US tooltip string.

Tryserver results are green:
http://tbpl.mozilla.org/?tree=Try&rev=281be3877d80
Attachment #536166 - Flags: review?(dtownsend)
Comment on attachment 536166 [details] [diff] [review]
Patch v1

Review of attachment 536166 [details] [diff] [review]:
-----------------------------------------------------------------

This makes things inconsistent with the global-warning cases elsewhere. Moving the class down one level doesn't seem to really help much so I'd prefer to leave it where it is. I'd be ok with adding a class to the link, something like "global-info-link" perhaps if that makes life easier.
Attachment #536166 - Flags: review?(dtownsend) → review-
Attached patch Patch v2Splinter Review
As discussed on IRC we want to set a 'global-info' class for the hbox. That patch updates that part.
Attachment #536166 - Attachment is obsolete: true
Attachment #536456 - Flags: review?(dtownsend)
Comment on attachment 536456 [details] [diff] [review]
Patch v2

Review of attachment 536456 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #536456 - Flags: review?(dtownsend) → review+
Why is global-info-plugincheck a class rather than an id?
Arguably for this case it need not be, but I'd rather keep it consistent with the other cases which need to be classes as they are used multiple times.
http://hg.mozilla.org/projects/cedar/rev/66efdc6a98c5
Flags: in-testsuite?
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Comment on attachment 536456 [details] [diff] [review]
Patch v2

It would be helpful for us to have this patch also on mozilla-aurora so we can add support for it in our Mozmill tests right away.
Attachment #536456 - Flags: approval-mozilla-aurora?
(In reply to comment #6)
> Arguably for this case it need not be, but I'd rather keep it consistent
> with the other cases which need to be classes as they are used multiple
> times.

Having classes for repeating stuff and ids for unique stuff seems pretty consistent to me.
Pushed:
http://hg.mozilla.org/mozilla-central/rev/66efdc6a98c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Comment on attachment 536456 [details] [diff] [review]
Patch v2

I like testing goodness, but this feels like something we can just pick up in the next merge - doesn't seem like there's a lot of reason to take the change on aurora. Am I underestimating the value?
Attachment #536456 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
It's fine. We simply will wait with the creation of any test which covers that part.
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus-
Blocks: 666553
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110622 Firefox/7.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.