Closed Bug 660844 Opened 10 years ago Closed 8 years ago

Intermittent browser_tabs.js | Test timed out

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

patch v2
953 bytes, patch
mfinkle
: review+
Details | Diff | Splinter Review 
Two of the last three,

http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1306833225.1306834106.8901.gz
Android Tegra 250 mozilla-central opt test browser-chrome on 2011/05/31 02:13:45 
s: tegra-083

TEST-PASS | chrome://mochitests/content/browser/mobile/chrome/tests/browser_tabs.js | Tabs container size should be equal to the number of columns and margins
{bug 660843 spew}
{gc spew from bug 508128}
TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/tests/browser_tabs.js | Console message: [JavaScript Error: "uncaught exception: waitFor timeout"]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/mobile/chrome/tests/browser_tabs.js | Test timed out
INFO TEST-END | chrome://mochitests/content/browser/mobile/chrome/tests/browser_tabs.js | finished in 30060ms


http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1306842877.1306844498.28871.gz
Android Tegra 250 mozilla-central opt test browser-chrome on 2011/05/31 04:54:37 
s: tegra-083

(same spot, same spew, 30097ms)
In the log above, the error is preceded by
TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/tests/browser_tabs.js | Console message: [JavaScript Error: "this._container is undefined" {file: "chrome://browser/content/tabs.xml" line: 91}]
TEST-INFO | chrome://mochitests/content/browser/mobile/chrome/tests/browser_tabs.js | Console message: [JavaScript Error: "uninit is not defined" {file: "about:home" line: 1}]
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attached patch patch (obsolete) — — Splinter Review 
I think this should fix the exception in comment 99.  Pushed to Try: https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=af646362e16d
Attached patch patch v2 — — Splinter Review 
This fixes a regression from bug 686380 that made this test perma-orange.  This probably won't fix all the failures, because this test was already a frequent intermittent-orange before bug 686380 landed.

The error is because we are now calling removeTab() twice for the closed tab - once in _onUndo directly and once in _onUndo -> onreloadtab -> undoCloseTab -> addTab -> removeClosedTab.  The patch uses removeClosedTab instead, because it already has a check to prevent this.
Attachment #561238 - Attachment is obsolete: true
Attachment #561264 - Flags: review?(mark.finkle)
Comment on attachment 561264 [details] [diff] [review]
patch v2

Nice catch
Attachment #561264 - Flags: review?(mark.finkle) → review+
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/355ffd653a9d

This bug should stay open after the merge, since I'm pretty sure this will not fix all of the failures.
Whiteboard: [orange] → [orange][inbound - DO NOT RESOLVE (comment 107)]
Whiteboard: [orange][inbound - DO NOT RESOLVE (comment 107)] → [orange]
Assignee: mbrubeck → nobody
Whiteboard: [orange]
Resolving WFM keyword:intermittent-failure bugs last modified >3 months ago, whose whiteboard contains none of:
{random,disabled,marked,fuzzy,todo,fails,failing,annotated,time-bomb,leave open}

There will inevitably be some false positives; for that (and the bugspam) I apologise. Filter on orangewfm.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.